GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-19 13:11:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

video: fbdev/mmp/core: Use struct_size() in kzalloc()

Browse source 
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct mmp_path {
	...
        struct mmp_overlay overlays[0];
};

size = sizeof(struct mmp_path) + count * sizeof(struct mmp_overlay);
instance = kzalloc(size, GFP_KERNEL)

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, overlays, count), GFP_KERNEL)

Notice that, in this case, variable size is not necessary, hence it
is removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190807161312.GA26835@embeddedor
This commit is contained in:
Gustavo A. R. Silva 2019-08-07 11:13:12 -05:00 • committed by Bartlomiej Zolnierkiewicz
parent 2012f7762e
commit 06b1f4b9f2
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/video/fbdev/mmp/core.c
View file

@ -153,13 +153,11 @@ EXPORT_SYMBOL_GPL(mmp_get_path);
struct mmp_path *mmp_register_path(struct mmp_path_info *info) struct mmp_path *mmp_register_path(struct mmp_path_info *info)
{ {
int i; int i;
size_t size;
struct mmp_path *path = NULL; struct mmp_path *path = NULL;
struct mmp_panel *panel; struct mmp_panel *panel;
size = sizeof(struct mmp_path) path = kzalloc(struct_size(path, overlays, info->overlay_num),
+ sizeof(struct mmp_overlay) * info->overlay_num; GFP_KERNEL);
path = kzalloc(size, GFP_KERNEL);
if (!path) if (!path)
return NULL; return NULL;