GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-14 10:37:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

xfs: Plug memory leak in xfs_attrmulti_attr_set

Browse source 
When setting attributes via XFS_IOC_ATTRMULTI_BY_HANDLE, the user-space
buffer is copied into a new kernel-space buffer via memdup_user; that
buffer then isn't freed.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Andreas Gruenbacher 2015-11-03 12:53:54 +11:00 • committed by Dave Chinner
parent 86a21c7974
commit 09cb22d2a5
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
fs/xfs/xfs_ioctl.c
View file

@ -482,6 +482,7 @@ xfs_attrmulti_attr_set(
__uint32_t flags) __uint32_t flags)
{ {
unsigned char *kbuf; unsigned char *kbuf;
int error;
if (IS_IMMUTABLE(inode) || IS_APPEND(inode)) if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
return -EPERM; return -EPERM;
@ -492,7 +493,9 @@ xfs_attrmulti_attr_set(
if (IS_ERR(kbuf)) if (IS_ERR(kbuf))
return PTR_ERR(kbuf); return PTR_ERR(kbuf);
return xfs_attr_set(XFS_I(inode), name, kbuf, len, flags); error = xfs_attr_set(XFS_I(inode), name, kbuf, len, flags);
kfree(kbuf);
return error;
} }
int int