From 0d76502172d83e1e09aedbdced3d8be0ef1abcb5 Mon Sep 17 00:00:00 2001 From: Baokun Li Date: Mon, 15 Nov 2021 09:31:43 +0800 Subject: [PATCH] ubifs: fix double return leb in ubifs_garbage_collect If ubifs_garbage_collect_leb() returns -EAGAIN and enters the "out" branch, ubifs_return_leb will execute twice on the same lnum. This can cause data loss in concurrency situations. Reported-by: Hulk Robot Signed-off-by: Baokun Li Signed-off-by: Richard Weinberger --- fs/ubifs/gc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c index 05e1eeae8457..1f74a127fe3a 100644 --- a/fs/ubifs/gc.c +++ b/fs/ubifs/gc.c @@ -758,6 +758,8 @@ int ubifs_garbage_collect(struct ubifs_info *c, int anyway) err = ubifs_return_leb(c, lp.lnum); if (err) ret = err; + /* Maybe double return LEB if goto out */ + lp.lnum = -1; break; } goto out;