mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-07-16 03:22:27 +00:00
Pass consistent param->type to fs_parse()
As it is, vfs_parse_fs_string() makes "foo" and "foo=" indistinguishable; both get fs_value_is_string for ->type and NULL for ->string. To make it even more unpleasant, that combination is impossible to produce with fsconfig(). Much saner rules would be "foo" => fs_value_is_flag, NULL "foo=" => fs_value_is_string, "" "foo=bar" => fs_value_is_string, "bar" All cases are distinguishable, all results are expressable by fsconfig(), ->has_value checks are much simpler that way (to the point of the field being useless) and quite a few regressions go away (gfs2 has no business accepting -o nodebug=, for example). Partially based upon patches from Miklos. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
7dc2993a9e
commit
0f89589a8c
4 changed files with 16 additions and 20 deletions
|
@ -72,7 +72,6 @@ struct fs_parameter_description {
|
|||
*/
|
||||
struct fs_parse_result {
|
||||
bool negated; /* T if param was "noxxx" */
|
||||
bool has_value; /* T if value supplied to param */
|
||||
union {
|
||||
bool boolean; /* For spec_bool */
|
||||
int int_32; /* For spec_s32/spec_enum */
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue