GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-03-20 22:25:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

sound: hiface: move to use usb_control_msg_send()

Browse source 
The usb_control_msg_send() call can return an error if a "short" write
happens, so move the driver over to using that call instead.

v2: API change of use usb_control_msg_send()

Cc: Jaroslav Kysela <perex@perex.cz>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200914153756.3412156-10-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20200923134348.23862-14-oneukum@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2020-09-23 15:43:47 +02:00
parent 6d2d427e3b
commit 10fbd979bd
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
sound/usb/hiface/pcm.c
View file

@ -156,16 +156,14 @@ static int hiface_pcm_set_rate(struct pcm_runtime *rt, unsigned int rate)
* This control message doesn't have any ack from the * This control message doesn't have any ack from the
* other side * other side
*/ */
ret = usb_control_msg(device, usb_sndctrlpipe(device, 0), ret = usb_control_msg_send(device, 0,
HIFACE_SET_RATE_REQUEST, HIFACE_SET_RATE_REQUEST,
USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_OTHER, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_OTHER,
rate_value, 0, NULL, 0, 100); rate_value, 0, NULL, 0, 100, GFP_KERNEL);
if (ret < 0) { if (ret)
dev_err(&device->dev, "Error setting samplerate %d.\n", rate); dev_err(&device->dev, "Error setting samplerate %d.\n", rate);
return ret;
}
return 0; return ret;
} }
static struct pcm_substream *hiface_pcm_get_substream(struct snd_pcm_substream static struct pcm_substream *hiface_pcm_get_substream(struct snd_pcm_substream