mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-03-16 12:14:06 +00:00
pwm: cros-ec: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Guenter Roeck <groeck@chromium.org> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
parent
d5806ac636
commit
159a61a7b5
1 changed files with 2 additions and 4 deletions
|
@ -329,14 +329,12 @@ static int cros_ec_pwm_probe(struct platform_device *pdev)
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int cros_ec_pwm_remove(struct platform_device *dev)
|
||||
static void cros_ec_pwm_remove(struct platform_device *dev)
|
||||
{
|
||||
struct cros_ec_pwm_device *ec_pwm = platform_get_drvdata(dev);
|
||||
struct pwm_chip *chip = &ec_pwm->chip;
|
||||
|
||||
pwmchip_remove(chip);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_OF
|
||||
|
@ -350,7 +348,7 @@ MODULE_DEVICE_TABLE(of, cros_ec_pwm_of_match);
|
|||
|
||||
static struct platform_driver cros_ec_pwm_driver = {
|
||||
.probe = cros_ec_pwm_probe,
|
||||
.remove = cros_ec_pwm_remove,
|
||||
.remove_new = cros_ec_pwm_remove,
|
||||
.driver = {
|
||||
.name = "cros-ec-pwm",
|
||||
.of_match_table = of_match_ptr(cros_ec_pwm_of_match),
|
||||
|
|
Loading…
Add table
Reference in a new issue