bridge: multicast flood

Fix unsafe usage of RCU. Would never work on Alpha SMP because
of lack of rcu_dereference()

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
stephen hemminger 2010-04-27 15:01:05 +00:00 committed by David S. Miller
parent 7e80c12448
commit 168d40ee3d

View file

@ -216,7 +216,7 @@ static void br_multicast_flood(struct net_bridge_mdb_entry *mdst,
prev = NULL; prev = NULL;
rp = br->router_list.first; rp = rcu_dereference(br->router_list.first);
p = mdst ? mdst->ports : NULL; p = mdst ? mdst->ports : NULL;
while (p || rp) { while (p || rp) {
lport = p ? p->port : NULL; lport = p ? p->port : NULL;
@ -233,7 +233,7 @@ static void br_multicast_flood(struct net_bridge_mdb_entry *mdst,
if ((unsigned long)lport >= (unsigned long)port) if ((unsigned long)lport >= (unsigned long)port)
p = p->next; p = p->next;
if ((unsigned long)rport >= (unsigned long)port) if ((unsigned long)rport >= (unsigned long)port)
rp = rp->next; rp = rcu_dereference(rp->next);
} }
if (!prev) if (!prev)