GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-07-04 13:21:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

NTB: variable dereferenced before check

Browse source 
Correct instances of variable dereferencing before checking its value on
the functions exported to the client drivers.  Also, add sanity checks
for all exported functions.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jon Mason <jon.mason@intel.com>
This commit is contained in:
Jon Mason 2013-01-22 11:35:40 -07:00
parent f722406faa
commit 186f27ff9f
No known key found for this signature in database
GPG key ID: 6E664BAC7A8BD223
1 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
drivers/ntb/ntb_transport.c
View file

@ -1210,12 +1210,14 @@ EXPORT_SYMBOL_GPL(ntb_transport_create_queue);
*/ */
void ntb_transport_free_queue(struct ntb_transport_qp *qp) void ntb_transport_free_queue(struct ntb_transport_qp *qp)
{ {
struct pci_dev *pdev = ntb_query_pdev(qp->ndev); struct pci_dev *pdev;
struct ntb_queue_entry *entry; struct ntb_queue_entry *entry;
if (!qp) if (!qp)
return; return;
pdev = ntb_query_pdev(qp->ndev);
cancel_delayed_work_sync(&qp->link_work); cancel_delayed_work_sync(&qp->link_work);
ntb_unregister_db_callback(qp->ndev, qp->qp_num); ntb_unregister_db_callback(qp->ndev, qp->qp_num);
@ -1371,12 +1373,13 @@ EXPORT_SYMBOL_GPL(ntb_transport_link_up);
*/ */
void ntb_transport_link_down(struct ntb_transport_qp *qp) void ntb_transport_link_down(struct ntb_transport_qp *qp)
{ {
struct pci_dev *pdev = ntb_query_pdev(qp->ndev); struct pci_dev *pdev;
int rc, val; int rc, val;
if (!qp) if (!qp)
return; return;
pdev = ntb_query_pdev(qp->ndev);
qp->client_ready = NTB_LINK_DOWN; qp->client_ready = NTB_LINK_DOWN;
rc = ntb_read_local_spad(qp->ndev, QP_LINKS, &val); rc = ntb_read_local_spad(qp->ndev, QP_LINKS, &val);
@ -1408,6 +1411,9 @@ EXPORT_SYMBOL_GPL(ntb_transport_link_down);
*/ */
bool ntb_transport_link_query(struct ntb_transport_qp *qp) bool ntb_transport_link_query(struct ntb_transport_qp *qp)
{ {
if (!qp)
return false;
return qp->qp_link == NTB_LINK_UP; return qp->qp_link == NTB_LINK_UP;
} }
EXPORT_SYMBOL_GPL(ntb_transport_link_query); EXPORT_SYMBOL_GPL(ntb_transport_link_query);
@ -1422,6 +1428,9 @@ EXPORT_SYMBOL_GPL(ntb_transport_link_query);
*/ */
unsigned char ntb_transport_qp_num(struct ntb_transport_qp *qp) unsigned char ntb_transport_qp_num(struct ntb_transport_qp *qp)
{ {
if (!qp)
return 0;
return qp->qp_num; return qp->qp_num;
} }
EXPORT_SYMBOL_GPL(ntb_transport_qp_num); EXPORT_SYMBOL_GPL(ntb_transport_qp_num);
@ -1436,6 +1445,9 @@ EXPORT_SYMBOL_GPL(ntb_transport_qp_num);
*/ */
unsigned int ntb_transport_max_size(struct ntb_transport_qp *qp) unsigned int ntb_transport_max_size(struct ntb_transport_qp *qp)
{ {
if (!qp)
return 0;
return qp->tx_max_frame - sizeof(struct ntb_payload_header); return qp->tx_max_frame - sizeof(struct ntb_payload_header);
} }
EXPORT_SYMBOL_GPL(ntb_transport_max_size); EXPORT_SYMBOL_GPL(ntb_transport_max_size);