GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-29 10:01:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ASoC: xlnx: fix error handling in xlnx_formatter_pcm_probe

Browse source 
Currently, if platform_get_irq_byname() fails, the returned error
turns into a huge value, once it is being store into a variable
of type unsigned int, hence never actually reporting any error
and causing unexpected behavior when using the values stored
in aud_drv_data->s2mm_irq and aud_drv_data->mm2s_irq.

Fix this by changing the type of variables s2mm_irq and mm2s_irq in
structure xlnx_pcm_drv_data from unsigned int to int.

Addresses-Coverity-ID: 1476096 ("Unsigned compared against 0")
Fixes: 796175a94a7f ("ASoC: xlnx: add pcm formatter platform driver")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Gustavo A. R. Silva 2018-12-26 15:11:06 -06:00 • committed by Mark Brown
parent f5758544d9
commit 1d38b4e903
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
sound/soc/xilinx/xlnx_formatter_pcm.c
View file

@ -76,8 +76,8 @@ struct xlnx_pcm_drv_data {
void __iomem *mmio; void __iomem *mmio;
bool s2mm_presence; bool s2mm_presence;
bool mm2s_presence; bool mm2s_presence;
unsigned int s2mm_irq; int s2mm_irq;
unsigned int mm2s_irq; int mm2s_irq;
struct snd_pcm_substream *play_stream; struct snd_pcm_substream *play_stream;
struct snd_pcm_substream *capture_stream; struct snd_pcm_substream *capture_stream;
struct clk *axi_clk; struct clk *axi_clk;