mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-06-27 00:51:35 +00:00
module: put modules in list much earlier.
Prarit's excellent bug report:
> In recent Fedora releases (F17 & F18) some users have reported seeing
> messages similar to
>
> [ 15.478160] kvm: Could not allocate 304 bytes percpu data
> [ 15.478174] PERCPU: allocation failed, size=304 align=32, alloc from
> reserved chunk failed
>
> during system boot. In some cases, users have also reported seeing this
> message along with a failed load of other modules.
>
> What is happening is systemd is loading an instance of the kvm module for
> each cpu found (see commit e9bda3b
). When the module load occurs the kernel
> currently allocates the modules percpu data area prior to checking to see
> if the module is already loaded or is in the process of being loaded. If
> the module is already loaded, or finishes load, the module loading code
> releases the current instance's module's percpu data.
Now we have a new state MODULE_STATE_UNFORMED, we can insert the
module into the list (and thus guarantee its uniqueness) before we
allocate the per-cpu region.
Reported-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Tested-by: Prarit Bhargava <prarit@redhat.com>
This commit is contained in:
parent
0d21b0e347
commit
1fb9341ac3
2 changed files with 50 additions and 41 deletions
|
@ -55,6 +55,7 @@ static inline unsigned long bug_addr(const struct bug_entry *bug)
|
|||
}
|
||||
|
||||
#ifdef CONFIG_MODULES
|
||||
/* Updates are protected by module mutex */
|
||||
static LIST_HEAD(module_bug_list);
|
||||
|
||||
static const struct bug_entry *module_find_bug(unsigned long bugaddr)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue