mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-06-20 05:31:15 +00:00
kexec: move vmcoreinfo out of the kernel's .bss section
As Eric said, "what we need to do is move the variable vmcoreinfo_note out of the kernel's .bss section. And modify the code to regenerate and keep this information in something like the control page. Definitely something like this needs a page all to itself, and ideally far away from any other kernel data structures. I clearly was not watching closely the data someone decided to keep this silly thing in the kernel's .bss section." This patch allocates extra pages for these vmcoreinfo_XXX variables, one advantage is that it enhances some safety of vmcoreinfo, because vmcoreinfo now is kept far away from other kernel data structures. Link: http://lkml.kernel.org/r/1493281021-20737-1-git-send-email-xlpang@redhat.com Signed-off-by: Xunlei Pang <xlpang@redhat.com> Tested-by: Michael Holzheu <holzheu@linux.vnet.ibm.com> Reviewed-by: Juergen Gross <jgross@suse.com> Suggested-by: Eric Biederman <ebiederm@xmission.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Dave Young <dyoung@redhat.com> Cc: Hari Bathini <hbathini@linux.vnet.ibm.com> Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
112166f88c
commit
203e9e4121
8 changed files with 29 additions and 21 deletions
|
@ -134,7 +134,7 @@ static ssize_t vmcoreinfo_show(struct kobject *kobj,
|
|||
{
|
||||
phys_addr_t vmcore_base = paddr_vmcoreinfo_note();
|
||||
return sprintf(buf, "%pa %x\n", &vmcore_base,
|
||||
(unsigned int)sizeof(vmcoreinfo_note));
|
||||
(unsigned int)VMCOREINFO_NOTE_SIZE);
|
||||
}
|
||||
KERNEL_ATTR_RO(vmcoreinfo);
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue