GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-03-18 05:04:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[SCSI] sd, sym53c8xx: Remove warnings after vsprintf %pV introducation.

Browse source 
GCC warns about empty printf format strings, and after
the addition of %pV these existing such cases in the
scsi driver layer were exposed enough for the compiler
to start seeing them.

Based almost entirely upon a patch by Joe Perches.

[jejb: fix up sym53c8xx msg]
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
This commit is contained in:
David Miller 2010-08-31 13:35:31 -07:00 • committed by James Bottomley
parent 6f131ce1df
commit 2e4c332913
2 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/scsi/sd.c
View file

@ -2625,15 +2625,15 @@ module_exit(exit_sd);
static void sd_print_sense_hdr(struct scsi_disk *sdkp, static void sd_print_sense_hdr(struct scsi_disk *sdkp,
struct scsi_sense_hdr *sshdr) struct scsi_sense_hdr *sshdr)
{ {
sd_printk(KERN_INFO, sdkp, ""); sd_printk(KERN_INFO, sdkp, " ");
scsi_show_sense_hdr(sshdr); scsi_show_sense_hdr(sshdr);
sd_printk(KERN_INFO, sdkp, ""); sd_printk(KERN_INFO, sdkp, " ");
scsi_show_extd_sense(sshdr->asc, sshdr->ascq); scsi_show_extd_sense(sshdr->asc, sshdr->ascq);
} }
static void sd_print_result(struct scsi_disk *sdkp, int result) static void sd_print_result(struct scsi_disk *sdkp, int result)
{ {
sd_printk(KERN_INFO, sdkp, ""); sd_printk(KERN_INFO, sdkp, " ");
scsi_show_result(result); scsi_show_result(result);
} }

10
drivers/scsi/sym53c8xx_2/sym_hipd.c
View file

@ -72,10 +72,7 @@ static void sym_printl_hex(u_char *p, int n)
static void sym_print_msg(struct sym_ccb *cp, char *label, u_char *msg) static void sym_print_msg(struct sym_ccb *cp, char *label, u_char *msg)
{ {
if (label) sym_print_addr(cp->cmd, "%s: ", label);
sym_print_addr(cp->cmd, "%s: ", label);
else
sym_print_addr(cp->cmd, "");
spi_print_msg(msg); spi_print_msg(msg);
printf("\n"); printf("\n");
@ -4558,7 +4555,8 @@ static void sym_int_sir(struct sym_hcb *np)
switch (np->msgin [2]) { switch (np->msgin [2]) {
case M_X_MODIFY_DP: case M_X_MODIFY_DP:
if (DEBUG_FLAGS & DEBUG_POINTER) if (DEBUG_FLAGS & DEBUG_POINTER)
sym_print_msg(cp, NULL, np->msgin); sym_print_msg(cp, "extended msg ",
np->msgin);
tmp = (np->msgin[3]<<24) + (np->msgin[4]<<16) + tmp = (np->msgin[3]<<24) + (np->msgin[4]<<16) +
(np->msgin[5]<<8) + (np->msgin[6]); (np->msgin[5]<<8) + (np->msgin[6]);
sym_modify_dp(np, tp, cp, tmp); sym_modify_dp(np, tp, cp, tmp);
@ -4585,7 +4583,7 @@ static void sym_int_sir(struct sym_hcb *np)
*/ */
case M_IGN_RESIDUE: case M_IGN_RESIDUE:
if (DEBUG_FLAGS & DEBUG_POINTER) if (DEBUG_FLAGS & DEBUG_POINTER)
sym_print_msg(cp, NULL, np->msgin); sym_print_msg(cp, "1 or 2 byte ", np->msgin);
if (cp->host_flags & HF_SENSE) if (cp->host_flags & HF_SENSE)
OUTL_DSP(np, SCRIPTA_BA(np, clrack)); OUTL_DSP(np, SCRIPTA_BA(np, clrack));
else else