GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-03-19 13:44:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

video: Fix possible leak in of_get_videomode()

Browse source 
In case videomode_from_timings() fails in function of_get_videomode(), the
allocated display timing data is not freed in the exit path. Make sure that
display_timings_release() is called in any case. Detected by Coverity CID
1309681.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Christian Engelmayer 2015-07-11 19:46:11 +02:00 • committed by Tomi Valkeinen
parent 9e6e35edb3
commit 37b617f9be
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/video/of_videomode.c
View file

@ -44,11 +44,9 @@ int of_get_videomode(struct device_node *np, struct videomode *vm,
index = disp->native_mode; index = disp->native_mode;
ret = videomode_from_timings(disp, vm, index); ret = videomode_from_timings(disp, vm, index);
if (ret)
return ret;
display_timings_release(disp); display_timings_release(disp);
return 0; return ret;
} }
EXPORT_SYMBOL_GPL(of_get_videomode); EXPORT_SYMBOL_GPL(of_get_videomode);