ipc: clamp with min()

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Acked-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Peter Hurley 2013-04-30 19:14:25 -07:00 committed by Linus Torvalds
parent 08d7676083
commit 3d8fa456d5

View file

@ -41,8 +41,8 @@ struct msg_msgseg {
/* the next part of the message follows immediately */ /* the next part of the message follows immediately */
}; };
#define DATALEN_MSG (PAGE_SIZE-sizeof(struct msg_msg)) #define DATALEN_MSG (int)(PAGE_SIZE-sizeof(struct msg_msg))
#define DATALEN_SEG (PAGE_SIZE-sizeof(struct msg_msgseg)) #define DATALEN_SEG (int)(PAGE_SIZE-sizeof(struct msg_msgseg))
struct msg_msg *load_msg(const void __user *src, int len) struct msg_msg *load_msg(const void __user *src, int len)
{ {
@ -51,10 +51,7 @@ struct msg_msg *load_msg(const void __user *src, int len)
int err; int err;
int alen; int alen;
alen = len; alen = min(len, DATALEN_MSG);
if (alen > DATALEN_MSG)
alen = DATALEN_MSG;
msg = kmalloc(sizeof(*msg) + alen, GFP_KERNEL); msg = kmalloc(sizeof(*msg) + alen, GFP_KERNEL);
if (msg == NULL) if (msg == NULL)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
@ -72,9 +69,7 @@ struct msg_msg *load_msg(const void __user *src, int len)
pseg = &msg->next; pseg = &msg->next;
while (len > 0) { while (len > 0) {
struct msg_msgseg *seg; struct msg_msgseg *seg;
alen = len; alen = min(len, DATALEN_SEG);
if (alen > DATALEN_SEG)
alen = DATALEN_SEG;
seg = kmalloc(sizeof(*seg) + alen, seg = kmalloc(sizeof(*seg) + alen,
GFP_KERNEL); GFP_KERNEL);
if (seg == NULL) { if (seg == NULL) {
@ -113,19 +108,14 @@ struct msg_msg *copy_msg(struct msg_msg *src, struct msg_msg *dst)
if (src->m_ts > dst->m_ts) if (src->m_ts > dst->m_ts)
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
alen = len; alen = min(len, DATALEN_MSG);
if (alen > DATALEN_MSG)
alen = DATALEN_MSG;
memcpy(dst + 1, src + 1, alen); memcpy(dst + 1, src + 1, alen);
len -= alen; len -= alen;
dst_pseg = dst->next; dst_pseg = dst->next;
src_pseg = src->next; src_pseg = src->next;
while (len > 0) { while (len > 0) {
alen = len; alen = min(len, DATALEN_SEG);
if (alen > DATALEN_SEG)
alen = DATALEN_SEG;
memcpy(dst_pseg + 1, src_pseg + 1, alen); memcpy(dst_pseg + 1, src_pseg + 1, alen);
dst_pseg = dst_pseg->next; dst_pseg = dst_pseg->next;
len -= alen; len -= alen;
@ -148,9 +138,7 @@ int store_msg(void __user *dest, struct msg_msg *msg, int len)
int alen; int alen;
struct msg_msgseg *seg; struct msg_msgseg *seg;
alen = len; alen = min(len, DATALEN_MSG);
if (alen > DATALEN_MSG)
alen = DATALEN_MSG;
if (copy_to_user(dest, msg + 1, alen)) if (copy_to_user(dest, msg + 1, alen))
return -1; return -1;
@ -158,9 +146,7 @@ int store_msg(void __user *dest, struct msg_msg *msg, int len)
dest = ((char __user *)dest) + alen; dest = ((char __user *)dest) + alen;
seg = msg->next; seg = msg->next;
while (len > 0) { while (len > 0) {
alen = len; alen = min(len, DATALEN_SEG);
if (alen > DATALEN_SEG)
alen = DATALEN_SEG;
if (copy_to_user(dest, seg + 1, alen)) if (copy_to_user(dest, seg + 1, alen))
return -1; return -1;
len -= alen; len -= alen;