GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-07-07 23:11:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

tun: fix tun_chr_aio_read so that aio works

Browse source 
aio_read gets const struct iovec * but tun_chr_aio_read casts this to struct
iovec * and modifies the iovec. As a result, attempts to use io_submit
to get packets from a tun device fail with weird errors such as EINVAL.

Fix by using the new skb_copy_datagram_const_iovec.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Michael S. Tsirkin 2009-04-20 01:25:59 +00:00 • committed by David S. Miller
parent 0a1ec07a67
commit 43b39dcdbd
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
drivers/net/tun.c
View file

@ -683,7 +683,7 @@ static ssize_t tun_chr_aio_write(struct kiocb *iocb, const struct iovec *iv,
/* Put packet to the user space buffer */ /* Put packet to the user space buffer */
static __inline__ ssize_t tun_put_user(struct tun_struct *tun, static __inline__ ssize_t tun_put_user(struct tun_struct *tun,
struct sk_buff *skb, struct sk_buff *skb,
struct iovec *iv, int len) const struct iovec *iv, int len)
{ {
struct tun_pi pi = { 0, skb->protocol }; struct tun_pi pi = { 0, skb->protocol };
ssize_t total = 0; ssize_t total = 0;
@ -697,7 +697,7 @@ static __inline__ ssize_t tun_put_user(struct tun_struct *tun,
pi.flags |= TUN_PKT_STRIP; pi.flags |= TUN_PKT_STRIP;
} }
if (memcpy_toiovec(iv, (void *) &pi, sizeof(pi))) if (memcpy_toiovecend(iv, (void *) &pi, 0, sizeof(pi)))
return -EFAULT; return -EFAULT;
total += sizeof(pi); total += sizeof(pi);
} }
@ -730,14 +730,15 @@ static __inline__ ssize_t tun_put_user(struct tun_struct *tun,
gso.csum_offset = skb->csum_offset; gso.csum_offset = skb->csum_offset;
} /* else everything is zero */ } /* else everything is zero */
if (unlikely(memcpy_toiovec(iv, (void *)&gso, sizeof(gso)))) if (unlikely(memcpy_toiovecend(iv, (void *)&gso, total,
sizeof(gso))))
return -EFAULT; return -EFAULT;
total += sizeof(gso); total += sizeof(gso);
} }
len = min_t(int, skb->len, len); len = min_t(int, skb->len, len);
skb_copy_datagram_iovec(skb, 0, iv, len); skb_copy_datagram_const_iovec(skb, 0, iv, total, len);
total += len; total += len;
tun->dev->stats.tx_packets++; tun->dev->stats.tx_packets++;
@ -792,7 +793,7 @@ static ssize_t tun_chr_aio_read(struct kiocb *iocb, const struct iovec *iv,
} }
netif_wake_queue(tun->dev); netif_wake_queue(tun->dev);
ret = tun_put_user(tun, skb, (struct iovec *) iv, len); ret = tun_put_user(tun, skb, iv, len);
kfree_skb(skb); kfree_skb(skb);
break; break;
} }