mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-03-17 12:44:10 +00:00
ALSA: drivers: opl3: Fix incorrect use of vp->state
commit 2dee54b289
upstream.
Static analysis with scan-build has found an assignment to vp2 that is
never used. It seems that the check on vp->state > 0 should be actually
on vp2->state instead. Fix this.
This dates back to 2002, I found the offending commit from the git
history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git,
commit 91e39521bbf6 ("[PATCH] ALSA patch for 2.5.4")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20211212172025.470367-1-colin.i.king@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
1d078e358e
commit
4617ed5b11
1 changed files with 1 additions and 1 deletions
|
@ -397,7 +397,7 @@ void snd_opl3_note_on(void *p, int note, int vel, struct snd_midi_channel *chan)
|
|||
}
|
||||
if (instr_4op) {
|
||||
vp2 = &opl3->voices[voice + 3];
|
||||
if (vp->state > 0) {
|
||||
if (vp2->state > 0) {
|
||||
opl3_reg = reg_side | (OPL3_REG_KEYON_BLOCK +
|
||||
voice_offset + 3);
|
||||
reg_val = vp->keyon_reg & ~OPL3_KEYON_BIT;
|
||||
|
|
Loading…
Add table
Reference in a new issue