GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-26 00:21:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm/i915: Fix memory leak in intel_hdcp auth

Browse source 
Static code analysis tool reported memory leak in
intel_hdcp_auth_downstream. Fixing the memory leak.

v2: Rebase, move free to a cleanup label(Jani)

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180404225957.7457-1-radhakrishna.sripada@intel.com
This commit is contained in:
Radhakrishna Sripada 2018-04-04 15:59:57 -07:00 • committed by Jani Nikula
parent 40da1d310e
commit 46a67c4d16
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
drivers/gpu/drm/i915/intel_hdcp.c
View file

@ -435,7 +435,7 @@ int intel_hdcp_auth_downstream(struct intel_digital_port *intel_dig_port,
ret = shim->read_ksv_fifo(intel_dig_port, num_downstream, ksv_fifo); ret = shim->read_ksv_fifo(intel_dig_port, num_downstream, ksv_fifo);
if (ret) if (ret)
return ret; goto err;
/* /*
* When V prime mismatches, DP Spec mandates re-read of * When V prime mismatches, DP Spec mandates re-read of
@ -451,12 +451,15 @@ int intel_hdcp_auth_downstream(struct intel_digital_port *intel_dig_port,
if (i == tries) { if (i == tries) {
DRM_ERROR("V Prime validation failed.(%d)\n", ret); DRM_ERROR("V Prime validation failed.(%d)\n", ret);
return ret; goto err;
} }
DRM_DEBUG_KMS("HDCP is enabled (%d downstream devices)\n", DRM_DEBUG_KMS("HDCP is enabled (%d downstream devices)\n",
num_downstream); num_downstream);
return 0; ret = 0;
err:
kfree(ksv_fifo);
return ret;
} }
/* Implements Part 1 of the HDCP authorization procedure */ /* Implements Part 1 of the HDCP authorization procedure */