mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-07-23 07:12:09 +00:00
networking: make skb_put & friends return void pointers
It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions (skb_put, __skb_put and pskb_put) return void * and remove all the casts across the tree, adding a (u8 *) cast only where the unsigned char pointer was used directly, all done with the following spatch: @@ expression SKB, LEN; typedef u8; identifier fn = { skb_put, __skb_put }; @@ - *(fn(SKB, LEN)) + *(u8 *)fn(SKB, LEN) @@ expression E, SKB, LEN; identifier fn = { skb_put, __skb_put }; type T; @@ - E = ((T *)(fn(SKB, LEN))) + E = fn(SKB, LEN) which actually doesn't cover pskb_put since there are only three users overall. A handful of stragglers were converted manually, notably a macro in drivers/isdn/i4l/isdn_bsdcomp.c and, oddly enough, one of the many instances in net/bluetooth/hci_sock.c. In the former file, I also had to fix one whitespace problem spatch introduced. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
59ae1d127a
commit
4df864c1d9
145 changed files with 486 additions and 547 deletions
|
@ -863,7 +863,7 @@ static int rfcomm_queue_disc(struct rfcomm_dlc *d)
|
|||
if (!skb)
|
||||
return -ENOMEM;
|
||||
|
||||
cmd = (void *) __skb_put(skb, sizeof(*cmd));
|
||||
cmd = __skb_put(skb, sizeof(*cmd));
|
||||
cmd->addr = d->addr;
|
||||
cmd->ctrl = __ctrl(RFCOMM_DISC, 1);
|
||||
cmd->len = __len8(0);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue