GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-06 22:58:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm/tegra: falcon: Fix error handling

Browse source 
The ->alloc() callback in struct falcon_ops returns an ERR_PTR()-encoded
error code on failure, so it needs to be properly checked for, otherwise
subsequent code may dereference an invalid pointer.

Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
Thierry Reding 2018-11-23 13:06:38 +01:00
parent 0dc34e19f6
commit 4eab8c0ebd
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/gpu/drm/tegra/falcon.c
View file

@ -141,9 +141,9 @@ int falcon_load_firmware(struct falcon *falcon)
/* allocate iova space for the firmware */ /* allocate iova space for the firmware */
falcon->firmware.vaddr = falcon->ops->alloc(falcon, firmware->size, falcon->firmware.vaddr = falcon->ops->alloc(falcon, firmware->size,
&falcon->firmware.paddr); &falcon->firmware.paddr);
if (!falcon->firmware.vaddr) { if (IS_ERR(falcon->firmware.vaddr)) {
dev_err(falcon->dev, "dma memory mapping failed\n"); dev_err(falcon->dev, "DMA memory mapping failed\n");
return -ENOMEM; return PTR_ERR(falcon->firmware.vaddr);
} }
/* copy firmware image into local area. this also ensures endianness */ /* copy firmware image into local area. this also ensures endianness */