GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-24 07:31:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

scripts/gdb: use a generator instead of iterator for task list

Browse source 
The iterator does not return any task_struct from the thread_group list
because the first condition in the 'if not t or ...' will only be the
first time None.

Instead of keeping track of the state ourself in the next() function, we
fall back using Python's generator.

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Ben Widawsky <ben@bwidawsk.net>
Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Daniel Wagner 2015-02-17 13:47:41 -08:00 • committed by Linus Torvalds
parent 2478a8a15c
commit 54e2289a34
1 changed files with 17 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

44
scripts/gdb/linux/tasks.py
View file

@ -18,38 +18,28 @@ from linux import utils
task_type = utils.CachedType("struct task_struct") task_type = utils.CachedType("struct task_struct")
def task_lists():
global task_type
task_ptr_type = task_type.get_type().pointer()
init_task = gdb.parse_and_eval("init_task").address
t = g = init_task
class TaskList: while True:
def __init__(self): while True:
global task_type yield t
self.task_ptr_type = task_type.get_type().pointer()
self.init_task = gdb.parse_and_eval("init_task")
self.curr_group = self.init_task.address
self.curr_task = None
def __iter__(self): t = utils.container_of(t['thread_group']['next'],
return self task_ptr_type, "thread_group")
if t == g:
break
def __next__(self): t = g = utils.container_of(g['tasks']['next'],
t = self.curr_task task_ptr_type, "tasks")
if not t or t == self.curr_group: if t == init_task:
self.curr_group = \ return
utils.container_of(self.curr_group['tasks']['next'],
self.task_ptr_type, "tasks")
if self.curr_group == self.init_task.address:
raise StopIteration
t = self.curr_task = self.curr_group
else:
self.curr_task = \
utils.container_of(t['thread_group']['next'],
self.task_ptr_type, "thread_group")
return t
def next(self):
return self.__next__()
def get_task_by_pid(pid): def get_task_by_pid(pid):
for task in TaskList(): for task in task_lists():
if int(task['pid']) == pid: if int(task['pid']) == pid:
return task return task
return None return None