mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-03-16 04:04:06 +00:00
bpf/tests: Do not PASS tests without actually testing the result
[ Upstream commit 2b7e9f25e5
]
Each test case can have a set of sub-tests, where each sub-test can
run the cBPF/eBPF test snippet with its own data_size and expected
result. Before, the end of the sub-test array was indicated by both
data_size and result being zero. However, most or all of the internal
eBPF tests has a data_size of zero already. When such a test also had
an expected value of zero, the test was never run but reported as
PASS anyway.
Now the test runner always runs the first sub-test, regardless of the
data_size and result values. The sub-test array zero-termination only
applies for any additional sub-tests.
There are other ways fix it of course, but this solution at least
removes the surprise of eBPF tests with a zero result always succeeding.
Signed-off-by: Johan Almbladh <johan.almbladh@anyfinetworks.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20210721103822.3755111-1-johan.almbladh@anyfinetworks.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
620a0d0b97
commit
55bd26b7fe
1 changed files with 8 additions and 1 deletions
|
@ -6659,7 +6659,14 @@ static int run_one(const struct bpf_prog *fp, struct bpf_test *test)
|
|||
u64 duration;
|
||||
u32 ret;
|
||||
|
||||
if (test->test[i].data_size == 0 &&
|
||||
/*
|
||||
* NOTE: Several sub-tests may be present, in which case
|
||||
* a zero {data_size, result} tuple indicates the end of
|
||||
* the sub-test array. The first test is always run,
|
||||
* even if both data_size and result happen to be zero.
|
||||
*/
|
||||
if (i > 0 &&
|
||||
test->test[i].data_size == 0 &&
|
||||
test->test[i].result == 0)
|
||||
break;
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue