GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-07 15:18:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rsi: remove memset before memcpy

Browse source 
calling memcpy immediately after memset with the same region of memory
makes memset redundant.

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Himanshu Jha 2017-08-30 00:24:50 +05:30 • committed by Kalle Valo
parent 83ec489193
commit 66a3479e12
2 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/net/wireless/rsi/rsi_91x_sdio.c
View file

@ -584,7 +584,6 @@ static int rsi_sdio_load_data_master_write(struct rsi_hw *adapter,
} }
for (offset = 0, i = 0; i < num_blocks; i++, offset += block_size) { for (offset = 0, i = 0; i < num_blocks; i++, offset += block_size) {
memset(temp_buf, 0, block_size);
memcpy(temp_buf, ta_firmware + offset, block_size); memcpy(temp_buf, ta_firmware + offset, block_size);
lsb_address = (u16)base_address; lsb_address = (u16)base_address;
status = rsi_sdio_write_register_multiple status = rsi_sdio_write_register_multiple

1
drivers/net/wireless/rsi/rsi_91x_usb.c
View file

@ -439,7 +439,6 @@ static int rsi_usb_load_data_master_write(struct rsi_hw *adapter,
rsi_dbg(INFO_ZONE, "num_blocks: %d\n", num_blocks); rsi_dbg(INFO_ZONE, "num_blocks: %d\n", num_blocks);
for (cur_indx = 0, i = 0; i < num_blocks; i++, cur_indx += block_size) { for (cur_indx = 0, i = 0; i < num_blocks; i++, cur_indx += block_size) {
memset(temp_buf, 0, block_size);
memcpy(temp_buf, ta_firmware + cur_indx, block_size); memcpy(temp_buf, ta_firmware + cur_indx, block_size);
status = rsi_usb_write_register_multiple(adapter, base_address, status = rsi_usb_write_register_multiple(adapter, base_address,
(u8 *)(temp_buf), (u8 *)(temp_buf),