mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-03-16 12:14:06 +00:00
xfs: only allocate free space bitmap for xattr scrub if needed
The free space bitmap is only required if we're going to check the bestfree space at the end of an xattr leaf block. Therefore, we can reduce the memory requirements of this scrubber if we can determine that the xattr is in short format. Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Dave Chinner <dchinner@redhat.com>
This commit is contained in:
parent
6cee51e6d0
commit
674f0d0dc6
1 changed files with 28 additions and 3 deletions
|
@ -37,6 +37,29 @@ xchk_xattr_buf_cleanup(
|
|||
ab->value_sz = 0;
|
||||
}
|
||||
|
||||
/*
|
||||
* Allocate the free space bitmap if we're trying harder; there are leaf blocks
|
||||
* in the attr fork; or we can't tell if there are leaf blocks.
|
||||
*/
|
||||
static inline bool
|
||||
xchk_xattr_want_freemap(
|
||||
struct xfs_scrub *sc)
|
||||
{
|
||||
struct xfs_ifork *ifp;
|
||||
|
||||
if (sc->flags & XCHK_TRY_HARDER)
|
||||
return true;
|
||||
|
||||
if (!sc->ip)
|
||||
return true;
|
||||
|
||||
ifp = xfs_ifork_ptr(sc->ip, XFS_ATTR_FORK);
|
||||
if (!ifp)
|
||||
return false;
|
||||
|
||||
return xfs_ifork_has_extents(ifp);
|
||||
}
|
||||
|
||||
/*
|
||||
* Allocate enough memory to hold an attr value and attr block bitmaps,
|
||||
* reallocating the buffer if necessary. Buffer contents are not preserved
|
||||
|
@ -66,9 +89,11 @@ xchk_setup_xattr_buf(
|
|||
if (!ab->usedmap)
|
||||
return -ENOMEM;
|
||||
|
||||
ab->freemap = kvmalloc(bmp_sz, XCHK_GFP_FLAGS);
|
||||
if (!ab->freemap)
|
||||
return -ENOMEM;
|
||||
if (xchk_xattr_want_freemap(sc)) {
|
||||
ab->freemap = kvmalloc(bmp_sz, XCHK_GFP_FLAGS);
|
||||
if (!ab->freemap)
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
resize_value:
|
||||
if (ab->value_sz >= value_size)
|
||||
|
|
Loading…
Add table
Reference in a new issue