mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-03-16 04:04:06 +00:00
s390/ap: fix status returned by ap_qact()
[ Upstream commita2522c80f0
] Since commit159491f3b5
("s390/ap: rework assembler functions to use unions for in/out register variables") the function ap_qact() tries to grab the status from the wrong part of the register. Thus we always end up with zeros. Which is wrong, among others, because we detect failures via status.response_code. Signed-off-by: Halil Pasic <pasic@linux.ibm.com> Reported-by: Harald Freudenberger <freude@linux.ibm.com> Fixes:159491f3b5
("s390/ap: rework assembler functions to use unions for in/out register variables") Reviewed-by: Harald Freudenberger <freude@linux.ibm.com> Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
d1c5430057
commit
79acb83dc6
1 changed files with 4 additions and 1 deletions
|
@ -290,7 +290,10 @@ static inline struct ap_queue_status ap_qact(ap_qid_t qid, int ifbit,
|
|||
unsigned long reg0 = qid | (5UL << 24) | ((ifbit & 0x01) << 22);
|
||||
union {
|
||||
unsigned long value;
|
||||
struct ap_queue_status status;
|
||||
struct {
|
||||
u32 _pad;
|
||||
struct ap_queue_status status;
|
||||
};
|
||||
} reg1;
|
||||
unsigned long reg2;
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue