GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-03-30 19:15:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

CacheFiles: Fix error handling in cachefiles_determine_cache_security()

Browse source 
cachefiles_determine_cache_security() is expected to return with a
security override in place.  However, if set_create_files_as() fails, we
fail to do this.  In this case, we should just reinstate the security
override that was set by the caller.

Furthermore, if set_create_files_as() fails, we should dispose of the
new credentials we were in the process of creating.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
David Howells 2010-05-12 15:34:03 +01:00 • committed by Linus Torvalds
parent 91af708141
commit 7ac512aa82
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
fs/cachefiles/security.c
View file

@ -77,6 +77,8 @@ static int cachefiles_check_cache_dir(struct cachefiles_cache *cache,
/* /*
* check the security details of the on-disk cache * check the security details of the on-disk cache
* - must be called with security override in force * - must be called with security override in force
* - must return with a security override in force - even in the case of an
* error
*/ */
int cachefiles_determine_cache_security(struct cachefiles_cache *cache, int cachefiles_determine_cache_security(struct cachefiles_cache *cache,
struct dentry *root, struct dentry *root,
@ -99,6 +101,8 @@ int cachefiles_determine_cache_security(struct cachefiles_cache *cache,
* which create files */ * which create files */
ret = set_create_files_as(new, root->d_inode); ret = set_create_files_as(new, root->d_inode);
if (ret < 0) { if (ret < 0) {
abort_creds(new);
cachefiles_begin_secure(cache, _saved_cred);
_leave(" = %d [cfa]", ret); _leave(" = %d [cfa]", ret);
return ret; return ret;
} }