GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-22 06:32:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

cifs: Fix invalid check in __cifs_calc_signature()

Browse source 
The following check would never evaluate to true:
  > if (i == 0 && iov[0].iov_len <= 4)

Because 'i' always starts at 1.

This patch fixes it and also move the header checks outside the for loop
- which makes more sense.

Signed-off-by: Paulo Alcantara <palcantara@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Paulo Alcantara 2018-06-15 15:58:00 -03:00 • committed by Steve French
parent 35e2cc1ba7
commit 83ffdeadb4
1 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
fs/cifs/cifsencrypt.c
View file

@ -48,26 +48,23 @@ int __cifs_calc_signature(struct smb_rqst *rqst,
/* iov[0] is actual data and not the rfc1002 length for SMB2+ */ /* iov[0] is actual data and not the rfc1002 length for SMB2+ */
if (is_smb2) { if (is_smb2) {
rc = crypto_shash_update(shash, if (iov[0].iov_len <= 4)
iov[0].iov_base, iov[0].iov_len); return -EIO;
i = 0;
} else { } else {
if (n_vec < 2 || iov[0].iov_len != 4) if (n_vec < 2 || iov[0].iov_len != 4)
return -EIO; return -EIO;
i = 1; /* skip rfc1002 length */
} }
for (i = 1; i < n_vec; i++) { for (; i < n_vec; i++) {
if (iov[i].iov_len == 0) if (iov[i].iov_len == 0)
continue; continue;
if (iov[i].iov_base == NULL) { if (iov[i].iov_base == NULL) {
cifs_dbg(VFS, "null iovec entry\n"); cifs_dbg(VFS, "null iovec entry\n");
return -EIO; return -EIO;
} }
if (is_smb2) {
if (i == 0 && iov[0].iov_len <= 4)
break; /* nothing to sign or corrupt header */
} else
if (i == 1 && iov[1].iov_len <= 4)
break; /* nothing to sign or corrupt header */
rc = crypto_shash_update(shash, rc = crypto_shash_update(shash,
iov[i].iov_base, iov[i].iov_len); iov[i].iov_base, iov[i].iov_len);
if (rc) { if (rc) {