GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-22 22:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

platform/chrome: wilco_ec: Platform data shouldn't include kernel.h

Browse source 
Replace with appropriate types.h.

Also there is no need to include device.h, but mutex.h.
For the pointers to unknown structures use forward declarations.

In the *.c files we need to include all headers that provide APIs
being used in the module.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
This commit is contained in:
Andy Shevchenko 2020-02-05 11:48:28 +02:00 • committed by Enric Balletbo i Serra
parent 2b63eb961a
commit 8673e944b5
3 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/platform/chrome/wilco_ec/properties.c
View file

@ -3,8 +3,11 @@
* Copyright 2019 Google LLC * Copyright 2019 Google LLC
*/ */
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/platform_data/wilco-ec.h> #include <linux/platform_data/wilco-ec.h>
#include <linux/string.h> #include <linux/string.h>
#include <linux/types.h>
#include <asm/unaligned.h> #include <asm/unaligned.h>
/* Operation code; what the EC should do with the property */ /* Operation code; what the EC should do with the property */

4
drivers/platform/chrome/wilco_ec/sysfs.c
View file

@ -8,8 +8,12 @@
* See Documentation/ABI/testing/sysfs-platform-wilco-ec for more information. * See Documentation/ABI/testing/sysfs-platform-wilco-ec for more information.
*/ */
#include <linux/device.h>
#include <linux/kernel.h>
#include <linux/platform_data/wilco-ec.h> #include <linux/platform_data/wilco-ec.h>
#include <linux/string.h>
#include <linux/sysfs.h> #include <linux/sysfs.h>
#include <linux/types.h>
#define CMD_KB_CMOS 0x7C #define CMD_KB_CMOS 0x7C
#define SUB_CMD_KB_CMOS_AUTO_ON 0x03 #define SUB_CMD_KB_CMOS_AUTO_ON 0x03

8
include/linux/platform_data/wilco-ec.h
View file

@ -8,8 +8,8 @@
#ifndef WILCO_EC_H #ifndef WILCO_EC_H
#define WILCO_EC_H #define WILCO_EC_H
#include <linux/device.h> #include <linux/mutex.h>
#include <linux/kernel.h> #include <linux/types.h>
/* Message flags for using the mailbox() interface */ /* Message flags for using the mailbox() interface */
#define WILCO_EC_FLAG_NO_RESPONSE BIT(0) /* EC does not respond */ #define WILCO_EC_FLAG_NO_RESPONSE BIT(0) /* EC does not respond */
@ -17,6 +17,10 @@
/* Normal commands have a maximum 32 bytes of data */ /* Normal commands have a maximum 32 bytes of data */
#define EC_MAILBOX_DATA_SIZE 32 #define EC_MAILBOX_DATA_SIZE 32
struct device;
struct resource;
struct platform_device;
/** /**
* struct wilco_ec_device - Wilco Embedded Controller handle. * struct wilco_ec_device - Wilco Embedded Controller handle.
* @dev: Device handle. * @dev: Device handle.