mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-07-01 11:21:51 +00:00
Bluetooth: btusb: Fix old coding style issues
The btusb driver has been around for a while now and it is time to bring its coding style in sync with what has been done for the Bluetooth subsystem and other drivers. Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
This commit is contained in:
parent
6970c34cea
commit
89e7533d0a
1 changed files with 58 additions and 56 deletions
|
@ -302,8 +302,8 @@ static void btusb_intr_complete(struct urb *urb)
|
||||||
struct btusb_data *data = hci_get_drvdata(hdev);
|
struct btusb_data *data = hci_get_drvdata(hdev);
|
||||||
int err;
|
int err;
|
||||||
|
|
||||||
BT_DBG("%s urb %p status %d count %d", hdev->name,
|
BT_DBG("%s urb %p status %d count %d", hdev->name, urb, urb->status,
|
||||||
urb, urb->status, urb->actual_length);
|
urb->actual_length);
|
||||||
|
|
||||||
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
||||||
return;
|
return;
|
||||||
|
@ -367,8 +367,7 @@ static int btusb_submit_intr_urb(struct hci_dev *hdev, gfp_t mem_flags)
|
||||||
pipe = usb_rcvintpipe(data->udev, data->intr_ep->bEndpointAddress);
|
pipe = usb_rcvintpipe(data->udev, data->intr_ep->bEndpointAddress);
|
||||||
|
|
||||||
usb_fill_int_urb(urb, data->udev, pipe, buf, size,
|
usb_fill_int_urb(urb, data->udev, pipe, buf, size,
|
||||||
btusb_intr_complete, hdev,
|
btusb_intr_complete, hdev, data->intr_ep->bInterval);
|
||||||
data->intr_ep->bInterval);
|
|
||||||
|
|
||||||
urb->transfer_flags |= URB_FREE_BUFFER;
|
urb->transfer_flags |= URB_FREE_BUFFER;
|
||||||
|
|
||||||
|
@ -393,8 +392,8 @@ static void btusb_bulk_complete(struct urb *urb)
|
||||||
struct btusb_data *data = hci_get_drvdata(hdev);
|
struct btusb_data *data = hci_get_drvdata(hdev);
|
||||||
int err;
|
int err;
|
||||||
|
|
||||||
BT_DBG("%s urb %p status %d count %d", hdev->name,
|
BT_DBG("%s urb %p status %d count %d", hdev->name, urb, urb->status,
|
||||||
urb, urb->status, urb->actual_length);
|
urb->actual_length);
|
||||||
|
|
||||||
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
||||||
return;
|
return;
|
||||||
|
@ -455,8 +454,8 @@ static int btusb_submit_bulk_urb(struct hci_dev *hdev, gfp_t mem_flags)
|
||||||
|
|
||||||
pipe = usb_rcvbulkpipe(data->udev, data->bulk_rx_ep->bEndpointAddress);
|
pipe = usb_rcvbulkpipe(data->udev, data->bulk_rx_ep->bEndpointAddress);
|
||||||
|
|
||||||
usb_fill_bulk_urb(urb, data->udev, pipe,
|
usb_fill_bulk_urb(urb, data->udev, pipe, buf, size,
|
||||||
buf, size, btusb_bulk_complete, hdev);
|
btusb_bulk_complete, hdev);
|
||||||
|
|
||||||
urb->transfer_flags |= URB_FREE_BUFFER;
|
urb->transfer_flags |= URB_FREE_BUFFER;
|
||||||
|
|
||||||
|
@ -482,8 +481,8 @@ static void btusb_isoc_complete(struct urb *urb)
|
||||||
struct btusb_data *data = hci_get_drvdata(hdev);
|
struct btusb_data *data = hci_get_drvdata(hdev);
|
||||||
int i, err;
|
int i, err;
|
||||||
|
|
||||||
BT_DBG("%s urb %p status %d count %d", hdev->name,
|
BT_DBG("%s urb %p status %d count %d", hdev->name, urb, urb->status,
|
||||||
urb, urb->status, urb->actual_length);
|
urb->actual_length);
|
||||||
|
|
||||||
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
||||||
return;
|
return;
|
||||||
|
@ -604,8 +603,8 @@ static void btusb_tx_complete(struct urb *urb)
|
||||||
struct hci_dev *hdev = (struct hci_dev *)skb->dev;
|
struct hci_dev *hdev = (struct hci_dev *)skb->dev;
|
||||||
struct btusb_data *data = hci_get_drvdata(hdev);
|
struct btusb_data *data = hci_get_drvdata(hdev);
|
||||||
|
|
||||||
BT_DBG("%s urb %p status %d count %d", hdev->name,
|
BT_DBG("%s urb %p status %d count %d", hdev->name, urb, urb->status,
|
||||||
urb, urb->status, urb->actual_length);
|
urb->actual_length);
|
||||||
|
|
||||||
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
||||||
goto done;
|
goto done;
|
||||||
|
@ -630,8 +629,8 @@ static void btusb_isoc_tx_complete(struct urb *urb)
|
||||||
struct sk_buff *skb = urb->context;
|
struct sk_buff *skb = urb->context;
|
||||||
struct hci_dev *hdev = (struct hci_dev *)skb->dev;
|
struct hci_dev *hdev = (struct hci_dev *)skb->dev;
|
||||||
|
|
||||||
BT_DBG("%s urb %p status %d count %d", hdev->name,
|
BT_DBG("%s urb %p status %d count %d", hdev->name, urb, urb->status,
|
||||||
urb, urb->status, urb->actual_length);
|
urb->actual_length);
|
||||||
|
|
||||||
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
if (!test_bit(HCI_RUNNING, &hdev->flags))
|
||||||
goto done;
|
goto done;
|
||||||
|
@ -984,6 +983,7 @@ static void btusb_work(struct work_struct *work)
|
||||||
|
|
||||||
if (hdev->voice_setting & 0x0020) {
|
if (hdev->voice_setting & 0x0020) {
|
||||||
static const int alts[3] = { 2, 4, 5 };
|
static const int alts[3] = { 2, 4, 5 };
|
||||||
|
|
||||||
new_alts = alts[data->sco_num - 1];
|
new_alts = alts[data->sco_num - 1];
|
||||||
} else {
|
} else {
|
||||||
new_alts = data->sco_num;
|
new_alts = data->sco_num;
|
||||||
|
@ -1400,6 +1400,7 @@ static int btusb_setup_intel(struct hci_dev *hdev)
|
||||||
|
|
||||||
if (skb->data[0]) {
|
if (skb->data[0]) {
|
||||||
u8 evt_status = skb->data[0];
|
u8 evt_status = skb->data[0];
|
||||||
|
|
||||||
BT_ERR("%s enable Intel manufacturer mode event failed (%02x)",
|
BT_ERR("%s enable Intel manufacturer mode event failed (%02x)",
|
||||||
hdev->name, evt_status);
|
hdev->name, evt_status);
|
||||||
kfree_skb(skb);
|
kfree_skb(skb);
|
||||||
|
@ -1761,6 +1762,7 @@ static int btusb_probe(struct usb_interface *intf,
|
||||||
|
|
||||||
if (!id->driver_info) {
|
if (!id->driver_info) {
|
||||||
const struct usb_device_id *match;
|
const struct usb_device_id *match;
|
||||||
|
|
||||||
match = usb_match_id(intf, blacklist_table);
|
match = usb_match_id(intf, blacklist_table);
|
||||||
if (match)
|
if (match)
|
||||||
id = match;
|
id = match;
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue