GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-06 06:37:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

IB/cm: Remove now useless rcu_lock in dst_fetch_ha

Browse source 
This lock used to be protecting a call to dst_get_neighbour_noref,
however the below commit changed it to dst_neigh_lookup which no longer
requires rcu.

Access to nud_state, neigh_event_send or rdma_copy_addr does not require
RCU, so delete the lock.

Fixes: 02b619555a ("infiniband: Convert dst_fetch_ha() over to dst_neigh_lookup().")
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
This commit is contained in:
Jason Gunthorpe 2018-06-27 10:44:26 +03:00
parent 1517799965
commit 92ebb6a0a1
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/infiniband/core/addr.c
View file

@ -315,19 +315,17 @@ static int dst_fetch_ha(const struct dst_entry *dst,
int ret = 0; int ret = 0;
n = dst_neigh_lookup(dst, daddr); n = dst_neigh_lookup(dst, daddr);
if (!n)
return -ENODATA;
rcu_read_lock(); if (!(n->nud_state & NUD_VALID)) {
if (!n || !(n->nud_state & NUD_VALID)) { neigh_event_send(n, NULL);
if (n)
neigh_event_send(n, NULL);
ret = -ENODATA; ret = -ENODATA;
} else { } else {
rdma_copy_addr(dev_addr, dst->dev, n->ha); rdma_copy_addr(dev_addr, dst->dev, n->ha);
} }
rcu_read_unlock();
if (n) neigh_release(n);
neigh_release(n);
return ret; return ret;
} }