mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-03-17 20:54:10 +00:00
usb: Fix fall-through warnings for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break/return/fallthrough statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/a76da7ca5b4f41c13d27b298accb8222d0b04e61.1605896060.git.gustavoars@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
52a0372a38
commit
93c747ed00
12 changed files with 14 additions and 2 deletions
|
@ -678,6 +678,8 @@ static __poll_t ffs_ep0_poll(struct file *file, poll_table *wait)
|
||||||
mask |= (EPOLLIN | EPOLLOUT);
|
mask |= (EPOLLIN | EPOLLOUT);
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
case FFS_CLOSING:
|
case FFS_CLOSING:
|
||||||
break;
|
break;
|
||||||
case FFS_DEACTIVATED:
|
case FFS_DEACTIVATED:
|
||||||
|
|
|
@ -274,7 +274,7 @@ static void loopback_complete(struct usb_ep *ep, struct usb_request *req)
|
||||||
default:
|
default:
|
||||||
ERROR(cdev, "%s loop complete --> %d, %d/%d\n", ep->name,
|
ERROR(cdev, "%s loop complete --> %d, %d/%d\n", ep->name,
|
||||||
status, req->actual, req->length);
|
status, req->actual, req->length);
|
||||||
/* FALLTHROUGH */
|
fallthrough;
|
||||||
|
|
||||||
/* NOTE: since this driver doesn't maintain an explicit record
|
/* NOTE: since this driver doesn't maintain an explicit record
|
||||||
* of requests it submitted (just maintains qlen count), we
|
* of requests it submitted (just maintains qlen count), we
|
||||||
|
|
|
@ -559,6 +559,7 @@ static void source_sink_complete(struct usb_ep *ep, struct usb_request *req)
|
||||||
#if 1
|
#if 1
|
||||||
DBG(cdev, "%s complete --> %d, %d/%d\n", ep->name,
|
DBG(cdev, "%s complete --> %d, %d/%d\n", ep->name,
|
||||||
status, req->actual, req->length);
|
status, req->actual, req->length);
|
||||||
|
break;
|
||||||
#endif
|
#endif
|
||||||
case -EREMOTEIO: /* short read */
|
case -EREMOTEIO: /* short read */
|
||||||
break;
|
break;
|
||||||
|
|
|
@ -553,6 +553,7 @@ static int dummy_enable(struct usb_ep *_ep,
|
||||||
/* we'll fake any legal size */
|
/* we'll fake any legal size */
|
||||||
break;
|
break;
|
||||||
/* save a return statement */
|
/* save a return statement */
|
||||||
|
fallthrough;
|
||||||
default:
|
default:
|
||||||
goto done;
|
goto done;
|
||||||
}
|
}
|
||||||
|
@ -595,6 +596,7 @@ static int dummy_enable(struct usb_ep *_ep,
|
||||||
if (max <= 1023)
|
if (max <= 1023)
|
||||||
break;
|
break;
|
||||||
/* save a return statement */
|
/* save a return statement */
|
||||||
|
fallthrough;
|
||||||
default:
|
default:
|
||||||
goto done;
|
goto done;
|
||||||
}
|
}
|
||||||
|
|
|
@ -5276,7 +5276,7 @@ static int fotg210_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
|
||||||
*/
|
*/
|
||||||
if (urb->transfer_buffer_length > (16 * 1024))
|
if (urb->transfer_buffer_length > (16 * 1024))
|
||||||
return -EMSGSIZE;
|
return -EMSGSIZE;
|
||||||
/* FALLTHROUGH */
|
fallthrough;
|
||||||
/* case PIPE_BULK: */
|
/* case PIPE_BULK: */
|
||||||
default:
|
default:
|
||||||
if (!qh_urb_transaction(fotg210, urb, &qtd_list, mem_flags))
|
if (!qh_urb_transaction(fotg210, urb, &qtd_list, mem_flags))
|
||||||
|
|
|
@ -1447,6 +1447,7 @@ static int isp116x_bus_resume(struct usb_hcd *hcd)
|
||||||
val &= ~HCCONTROL_HCFS;
|
val &= ~HCCONTROL_HCFS;
|
||||||
val |= HCCONTROL_USB_RESUME;
|
val |= HCCONTROL_USB_RESUME;
|
||||||
isp116x_write_reg32(isp116x, HCCONTROL, val);
|
isp116x_write_reg32(isp116x, HCCONTROL, val);
|
||||||
|
break;
|
||||||
case HCCONTROL_USB_RESUME:
|
case HCCONTROL_USB_RESUME:
|
||||||
break;
|
break;
|
||||||
case HCCONTROL_USB_OPER:
|
case HCCONTROL_USB_OPER:
|
||||||
|
|
|
@ -1537,6 +1537,7 @@ max3421_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
|
||||||
__func__, urb->interval);
|
__func__, urb->interval);
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
break;
|
||||||
default:
|
default:
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
|
@ -1365,6 +1365,7 @@ __acquires(oxu->lock)
|
||||||
switch (urb->status) {
|
switch (urb->status) {
|
||||||
case -EINPROGRESS: /* success */
|
case -EINPROGRESS: /* success */
|
||||||
urb->status = 0;
|
urb->status = 0;
|
||||||
|
break;
|
||||||
default: /* fault */
|
default: /* fault */
|
||||||
break;
|
break;
|
||||||
case -EREMOTEIO: /* fault or normal */
|
case -EREMOTEIO: /* fault or normal */
|
||||||
|
|
|
@ -137,6 +137,7 @@ static void yurex_interrupt(struct urb *urb)
|
||||||
dev_err(&dev->interface->dev,
|
dev_err(&dev->interface->dev,
|
||||||
"%s - overflow with length %d, actual length is %d\n",
|
"%s - overflow with length %d, actual length is %d\n",
|
||||||
__func__, YUREX_BUF_SIZE, dev->urb->actual_length);
|
__func__, YUREX_BUF_SIZE, dev->urb->actual_length);
|
||||||
|
return;
|
||||||
case -ECONNRESET:
|
case -ECONNRESET:
|
||||||
case -ENOENT:
|
case -ENOENT:
|
||||||
case -ESHUTDOWN:
|
case -ESHUTDOWN:
|
||||||
|
|
|
@ -467,6 +467,7 @@ static void musb_do_idle(struct timer_list *t)
|
||||||
fallthrough;
|
fallthrough;
|
||||||
case OTG_STATE_A_IDLE:
|
case OTG_STATE_A_IDLE:
|
||||||
tusb_musb_set_vbus(musb, 0);
|
tusb_musb_set_vbus(musb, 0);
|
||||||
|
break;
|
||||||
default:
|
default:
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
|
@ -861,6 +861,7 @@ static int ms_count_freeblock(struct us_data *us, u16 PhyBlock)
|
||||||
case MS_LB_NOT_USED:
|
case MS_LB_NOT_USED:
|
||||||
case MS_LB_NOT_USED_ERASED:
|
case MS_LB_NOT_USED_ERASED:
|
||||||
Count++;
|
Count++;
|
||||||
|
break;
|
||||||
default:
|
default:
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
|
@ -690,6 +690,7 @@ static int uas_queuecommand_lck(struct scsi_cmnd *cmnd,
|
||||||
fallthrough;
|
fallthrough;
|
||||||
case DMA_TO_DEVICE:
|
case DMA_TO_DEVICE:
|
||||||
cmdinfo->state |= ALLOC_DATA_OUT_URB | SUBMIT_DATA_OUT_URB;
|
cmdinfo->state |= ALLOC_DATA_OUT_URB | SUBMIT_DATA_OUT_URB;
|
||||||
|
break;
|
||||||
case DMA_NONE:
|
case DMA_NONE:
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Reference in a new issue