GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-03-17 04:34:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ASoC: ops: Check bounds for second channel in snd_soc_put_volsw_sx()

Browse source 
The bounds checks in snd_soc_put_volsw_sx() are only being applied to the
first channel, meaning it is possible to write out of bounds values to the
second channel in stereo controls. Add appropriate checks.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220511134137.169575-2-broonie@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Mark Brown 2022-05-11 14:41:37 +01:00
parent 698813ba8c
commit 97eea946b9
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sound/soc/soc-ops.c
View file

@ -451,6 +451,12 @@ int snd_soc_put_volsw_sx(struct snd_kcontrol *kcontrol,
val_mask = mask << rshift;
val2 = (ucontrol->value.integer.value[1] + min) & mask;
if (mc->platform_max && val2 > mc->platform_max)
return -EINVAL;
if (val2 > max)
return -EINVAL;
val2 = val2 << rshift;
err = snd_soc_component_update_bits(component, reg2, val_mask,