sctp: pass a kernel pointer to sctp_setsockopt_reuse_port

Use the kernel pointer that sctp_setsockopt has available instead of
directly handling the user pointer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Christoph Hellwig 2020-07-19 09:22:22 +02:00 committed by David S. Miller
parent 5b8d3b2446
commit a42624669e

View file

@ -4214,11 +4214,9 @@ static int sctp_setsockopt_interleaving_supported(struct sock *sk,
return 0; return 0;
} }
static int sctp_setsockopt_reuse_port(struct sock *sk, char __user *optval, static int sctp_setsockopt_reuse_port(struct sock *sk, int *val,
unsigned int optlen) unsigned int optlen)
{ {
int val;
if (!sctp_style(sk, TCP)) if (!sctp_style(sk, TCP))
return -EOPNOTSUPP; return -EOPNOTSUPP;
@ -4228,10 +4226,7 @@ static int sctp_setsockopt_reuse_port(struct sock *sk, char __user *optval,
if (optlen < sizeof(int)) if (optlen < sizeof(int))
return -EINVAL; return -EINVAL;
if (get_user(val, (int __user *)optval)) sctp_sk(sk)->reuse = !!*val;
return -EFAULT;
sctp_sk(sk)->reuse = !!val;
return 0; return 0;
} }
@ -4645,7 +4640,7 @@ static int sctp_setsockopt(struct sock *sk, int level, int optname,
optlen); optlen);
break; break;
case SCTP_REUSE_PORT: case SCTP_REUSE_PORT:
retval = sctp_setsockopt_reuse_port(sk, optval, optlen); retval = sctp_setsockopt_reuse_port(sk, kopt, optlen);
break; break;
case SCTP_EVENT: case SCTP_EVENT:
retval = sctp_setsockopt_event(sk, optval, optlen); retval = sctp_setsockopt_event(sk, optval, optlen);