GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-28 01:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[PATCH] nfsd: nfs_replay_me

Browse source 
We are using NFS_REPLAY_ME as a special error value that is never leaked to
clients.  That works fine; the only problem is mixing host- and network-
endian values in the same objects.  Network-endian equivalent would work just
as fine; switch to it.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Trond Myklebust <trond.myklebust@fys.uio.no>
Acked-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Al Viro 2006-10-19 23:29:03 -07:00 • committed by Linus Torvalds
parent c7afef1f96
commit a90b061c0b
3 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
fs/nfsd/nfs4proc.c
View file

@ -177,7 +177,7 @@ nfsd4_open(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_open
/* check seqid for replay. set nfs4_owner */ /* check seqid for replay. set nfs4_owner */
status = nfsd4_process_open1(open); status = nfsd4_process_open1(open);
if (status == NFSERR_REPLAY_ME) { if (status == nfserr_replay_me) {
struct nfs4_replay *rp = &open->op_stateowner->so_replay; struct nfs4_replay *rp = &open->op_stateowner->so_replay;
fh_put(current_fh); fh_put(current_fh);
current_fh->fh_handle.fh_size = rp->rp_openfh_len; current_fh->fh_handle.fh_size = rp->rp_openfh_len;
@ -188,7 +188,7 @@ nfsd4_open(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_open
dprintk("nfsd4_open: replay failed" dprintk("nfsd4_open: replay failed"
" restoring previous filehandle\n"); " restoring previous filehandle\n");
else else
status = NFSERR_REPLAY_ME; status = nfserr_replay_me;
} }
if (status) if (status)
goto out; goto out;
@ -937,7 +937,7 @@ nfsd4_proc_compound(struct svc_rqst *rqstp,
} }
encode_op: encode_op:
if (op->status == NFSERR_REPLAY_ME) { if (op->status == nfserr_replay_me) {
op->replay = &replay_owner->so_replay; op->replay = &replay_owner->so_replay;
nfsd4_encode_replay(resp, op); nfsd4_encode_replay(resp, op);
status = op->status = op->replay->rp_status; status = op->status = op->replay->rp_status;

4
fs/nfsd/nfs4state.c
View file

@ -1477,7 +1477,7 @@ nfsd4_process_open1(struct nfsd4_open *open)
} }
if (open->op_seqid == sop->so_seqid - 1) { if (open->op_seqid == sop->so_seqid - 1) {
if (sop->so_replay.rp_buflen) if (sop->so_replay.rp_buflen)
return NFSERR_REPLAY_ME; return nfserr_replay_me;
/* The original OPEN failed so spectacularly /* The original OPEN failed so spectacularly
* that we don't even have replay data saved! * that we don't even have replay data saved!
* Therefore, we have no choice but to continue * Therefore, we have no choice but to continue
@ -2233,7 +2233,7 @@ check_replay:
if (seqid == sop->so_seqid - 1) { if (seqid == sop->so_seqid - 1) {
dprintk("NFSD: preprocess_seqid_op: retransmission?\n"); dprintk("NFSD: preprocess_seqid_op: retransmission?\n");
/* indicate replay to calling function */ /* indicate replay to calling function */
return NFSERR_REPLAY_ME; return nfserr_replay_me;
} }
printk("NFSD: preprocess_seqid_op: bad seqid (expected %d, got %d)\n", printk("NFSD: preprocess_seqid_op: bad seqid (expected %d, got %d)\n",
sop->so_seqid, seqid); sop->so_seqid, seqid);

1
include/linux/nfsd/nfsd.h
View file

@ -238,6 +238,7 @@ void nfsd_lockd_shutdown(void);
#define nfserr_badname __constant_htonl(NFSERR_BADNAME) #define nfserr_badname __constant_htonl(NFSERR_BADNAME)
#define nfserr_cb_path_down __constant_htonl(NFSERR_CB_PATH_DOWN) #define nfserr_cb_path_down __constant_htonl(NFSERR_CB_PATH_DOWN)
#define nfserr_locked __constant_htonl(NFSERR_LOCKED) #define nfserr_locked __constant_htonl(NFSERR_LOCKED)
#define nfserr_replay_me __constant_htonl(NFSERR_REPLAY_ME)
/* error codes for internal use */ /* error codes for internal use */
/* if a request fails due to kmalloc failure, it gets dropped. /* if a request fails due to kmalloc failure, it gets dropped.