GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-05 22:28:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

exec: kill unsafe BUG_ON(sig->count) checks

Browse source 
de_thread:

	if (atomic_read(&oldsighand->count) <= 1)
		BUG_ON(atomic_read(&sig->count) != 1);

This is not safe without the rmb() in between.  The results of two
correctly ordered __exit_signal()->atomic_dec_and_test()'s could be seen
out of order on our CPU.

The same is true for the "thread_group_empty()" case, __unhash_process()'s
changes could be seen before atomic_dec_and_test(&sig->count).

On some platforms (including i386) atomic_read() doesn't provide even the
compiler barrier, in that case these checks are simply racy.

Remove these BUG_ON()'s. Alternatively, we can do something like

	BUG_ON( ({ smp_rmb(); atomic_read(&sig->count) != 1; }) );

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2007-08-22 14:01:58 -07:00 • committed by Linus Torvalds
parent 5c076fce2e
commit abd96ecb29
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
fs/exec.c
View file

@ -784,7 +784,6 @@ static int de_thread(struct task_struct *tsk)
* and we can just re-use it all. * and we can just re-use it all.
*/ */
if (atomic_read(&oldsighand->count) <= 1) { if (atomic_read(&oldsighand->count) <= 1) {
BUG_ON(atomic_read(&sig->count) != 1);
signalfd_detach(tsk); signalfd_detach(tsk);
exit_itimers(sig); exit_itimers(sig);
return 0; return 0;
@ -929,8 +928,6 @@ no_thread_group:
if (leader) if (leader)
release_task(leader); release_task(leader);
BUG_ON(atomic_read(&sig->count) != 1);
if (atomic_read(&oldsighand->count) == 1) { if (atomic_read(&oldsighand->count) == 1) {
/* /*
* Now that we nuked the rest of the thread group, * Now that we nuked the rest of the thread group,