GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-07-03 04:42:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

bnx2x: correct reading of speed capabilities

Browse source 
When the bnx2x driver reads the port configuration - mask irrelevant bits.

Without this change, the unintended bits may cause the driver to needlessly
toggle the link, as a comparison in the link flap avoidance flow will show
that the old link did not advertise the same capabilities and thus cannot
be retained.

Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Yaniv Rosner 2013-05-01 04:27:57 +00:00 • committed by David S. Miller
parent be3e45810b
commit b0261926ef
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
View file

@ -10667,10 +10667,12 @@ static void bnx2x_get_port_hwinfo(struct bnx2x *bp)
bp->link_params.speed_cap_mask[0] = bp->link_params.speed_cap_mask[0] =
SHMEM_RD(bp, SHMEM_RD(bp,
dev_info.port_hw_config[port].speed_capability_mask); dev_info.port_hw_config[port].speed_capability_mask) &
PORT_HW_CFG_SPEED_CAPABILITY_D0_MASK;
bp->link_params.speed_cap_mask[1] = bp->link_params.speed_cap_mask[1] =
SHMEM_RD(bp, SHMEM_RD(bp,
dev_info.port_hw_config[port].speed_capability_mask2); dev_info.port_hw_config[port].speed_capability_mask2) &
PORT_HW_CFG_SPEED_CAPABILITY_D0_MASK;
bp->port.link_config[0] = bp->port.link_config[0] =
SHMEM_RD(bp, dev_info.port_feature_config[port].link_config); SHMEM_RD(bp, dev_info.port_feature_config[port].link_config);