mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-06-22 22:51:37 +00:00
bkl: Remove locked .ioctl file operation
The last user is gone, so we can safely remove this Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: John Kacur <jkacur@redhat.com> Cc: Al Viro <viro@ZenIV.linux.org.uk> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
This commit is contained in:
parent
c6d7ba8b12
commit
b19dd42faf
7 changed files with 13 additions and 51 deletions
|
@ -214,8 +214,7 @@ static long proc_reg_unlocked_ioctl(struct file *file, unsigned int cmd, unsigne
|
|||
{
|
||||
struct proc_dir_entry *pde = PDE(file->f_path.dentry->d_inode);
|
||||
long rv = -ENOTTY;
|
||||
long (*unlocked_ioctl)(struct file *, unsigned int, unsigned long);
|
||||
int (*ioctl)(struct inode *, struct file *, unsigned int, unsigned long);
|
||||
long (*ioctl)(struct file *, unsigned int, unsigned long);
|
||||
|
||||
spin_lock(&pde->pde_unload_lock);
|
||||
if (!pde->proc_fops) {
|
||||
|
@ -223,19 +222,11 @@ static long proc_reg_unlocked_ioctl(struct file *file, unsigned int cmd, unsigne
|
|||
return rv;
|
||||
}
|
||||
pde->pde_users++;
|
||||
unlocked_ioctl = pde->proc_fops->unlocked_ioctl;
|
||||
ioctl = pde->proc_fops->ioctl;
|
||||
ioctl = pde->proc_fops->unlocked_ioctl;
|
||||
spin_unlock(&pde->pde_unload_lock);
|
||||
|
||||
if (unlocked_ioctl) {
|
||||
rv = unlocked_ioctl(file, cmd, arg);
|
||||
if (rv == -ENOIOCTLCMD)
|
||||
rv = -EINVAL;
|
||||
} else if (ioctl) {
|
||||
WARN_ONCE(1, "Procfs ioctl handlers must use unlocked_ioctl, "
|
||||
"%pf will be called without the Bkl held\n", ioctl);
|
||||
rv = ioctl(file->f_path.dentry->d_inode, file, cmd, arg);
|
||||
}
|
||||
if (ioctl)
|
||||
rv = ioctl(file, cmd, arg);
|
||||
|
||||
pde_users_dec(pde);
|
||||
return rv;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue