GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-20 13:41:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fs: fix kernel_read prototype

Browse source 
Use proper ssize_t and size_t types for the return value and count
argument, move the offset last and make it an in/out argument like
all other read/write helpers, and make the buf argument a void pointer
to get rid of lots of casts in the callers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Christoph Hellwig 2017-09-01 17:39:13 +02:00 • committed by Al Viro
parent c41fbad015
commit bdd1d2d3d2
17 changed files with 69 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

12
kernel/sysctl_binary.c
View file

@ -986,8 +986,9 @@ static ssize_t bin_intvec(struct file *file,
size_t length = oldlen / sizeof(*vec);
char *str, *end;
int i;
loff_t pos = 0;
result = kernel_read(file, 0, buffer, BUFSZ - 1);
result = kernel_read(file, buffer, BUFSZ - 1, &pos);
if (result < 0)
goto out_kfree;
@ -1057,8 +1058,9 @@ static ssize_t bin_ulongvec(struct file *file,
size_t length = oldlen / sizeof(*vec);
char *str, *end;
int i;
loff_t pos = 0;
result = kernel_read(file, 0, buffer, BUFSZ - 1);
result = kernel_read(file, buffer, BUFSZ - 1, &pos);
if (result < 0)
goto out_kfree;
@ -1120,8 +1122,9 @@ static ssize_t bin_uuid(struct file *file,
if (oldval && oldlen) {
char buf[UUID_STRING_LEN + 1];
uuid_t uuid;
loff_t pos = 0;
result = kernel_read(file, 0, buf, sizeof(buf) - 1);
result = kernel_read(file, buf, sizeof(buf) - 1, &pos);
if (result < 0)
goto out;
@ -1154,8 +1157,9 @@ static ssize_t bin_dn_node_address(struct file *file,
char buf[15], *nodep;
unsigned long area, node;
__le16 dnaddr;
loff_t pos = 0;
result = kernel_read(file, 0, buf, sizeof(buf) - 1);
result = kernel_read(file, buf, sizeof(buf) - 1, &pos);
if (result < 0)
goto out;