GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-16 11:38:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rtnetlink: rtnl_link_register() sanity test

Browse source 
Before adding a struct rtnl_link_ops into link_ops list, check it doesnt
clash with a prior one.

Based on a previous patch from Alexander Smirnov

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2011-12-13 11:38:00 +00:00 • committed by David S. Miller
parent b43faac690
commit c63044f0d2
1 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
net/core/rtnetlink.c
View file

@ -273,6 +273,17 @@ EXPORT_SYMBOL_GPL(rtnl_unregister_all);
static LIST_HEAD(link_ops); static LIST_HEAD(link_ops);
static const struct rtnl_link_ops *rtnl_link_ops_get(const char *kind)
{
const struct rtnl_link_ops *ops;
list_for_each_entry(ops, &link_ops, list) {
if (!strcmp(ops->kind, kind))
return ops;
}
return NULL;
}
/** /**
* __rtnl_link_register - Register rtnl_link_ops with rtnetlink. * __rtnl_link_register - Register rtnl_link_ops with rtnetlink.
* @ops: struct rtnl_link_ops * to register * @ops: struct rtnl_link_ops * to register
@ -285,6 +296,9 @@ static LIST_HEAD(link_ops);
*/ */
int __rtnl_link_register(struct rtnl_link_ops *ops) int __rtnl_link_register(struct rtnl_link_ops *ops)
{ {
if (rtnl_link_ops_get(ops->kind))
return -EEXIST;
if (!ops->dellink) if (!ops->dellink)
ops->dellink = unregister_netdevice_queue; ops->dellink = unregister_netdevice_queue;
@ -351,17 +365,6 @@ void rtnl_link_unregister(struct rtnl_link_ops *ops)
} }
EXPORT_SYMBOL_GPL(rtnl_link_unregister); EXPORT_SYMBOL_GPL(rtnl_link_unregister);
static const struct rtnl_link_ops *rtnl_link_ops_get(const char *kind)
{
const struct rtnl_link_ops *ops;
list_for_each_entry(ops, &link_ops, list) {
if (!strcmp(ops->kind, kind))
return ops;
}
return NULL;
}
static size_t rtnl_link_get_size(const struct net_device *dev) static size_t rtnl_link_get_size(const struct net_device *dev)
{ {
const struct rtnl_link_ops *ops = dev->rtnl_link_ops; const struct rtnl_link_ops *ops = dev->rtnl_link_ops;