GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-03-17 20:54:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

net/sched: sch_qfq: use extack on errors messages

Browse source 
Some error messages are still being printed to dmesg.
Since extack is available, provide error messages there.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pedro Tammela 2023-04-22 12:56:10 -03:00 • committed by David S. Miller
parent 807cfded92
commit c69a9b023f
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
net/sched/sch_qfq.c
View file

@ -402,8 +402,8 @@ static int qfq_change_class(struct Qdisc *sch, u32 classid, u32 parentid,
int err; int err;
int delta_w; int delta_w;
if (tca[TCA_OPTIONS] == NULL) { if (NL_REQ_ATTR_CHECK(extack, NULL, tca, TCA_OPTIONS)) {
pr_notice("qfq: no options\n"); NL_SET_ERR_MSG_MOD(extack, "missing options");
return -EINVAL; return -EINVAL;
} }
@ -442,8 +442,9 @@ static int qfq_change_class(struct Qdisc *sch, u32 classid, u32 parentid,
delta_w = weight - (cl ? cl->agg->class_weight : 0); delta_w = weight - (cl ? cl->agg->class_weight : 0);
if (q->wsum + delta_w > QFQ_MAX_WSUM) { if (q->wsum + delta_w > QFQ_MAX_WSUM) {
pr_notice("qfq: total weight out of range (%d + %u)\n", NL_SET_ERR_MSG_FMT_MOD(extack,
delta_w, q->wsum); "total weight out of range (%d + %u)\n",
delta_w, q->wsum);
return -EINVAL; return -EINVAL;
} }