GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-07-23 23:32:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

RDMA/core: Return bool instead of int

Browse source 
Return bool for following internal and inline functions as their
underlying APIs return bool too.

1. cma_zero_addr()
2. cma_loopback_addr()
3. cma_any_addr()
4. ib_addr_any()
5. ib_addr_loopback()

While we are touching cma_loopback_addr(), remove extra white spaces
in it.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Daniel Jurgens <danielj@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Parav Pandit 2018-07-29 11:53:13 +03:00 • committed by Jason Gunthorpe
parent 05e0b86c41
commit ca3a8ace2b
2 changed files with 15 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

19
drivers/infiniband/core/cma.c
View file

@ -1046,7 +1046,7 @@ int rdma_init_qp_attr(struct rdma_cm_id *id, struct ib_qp_attr *qp_attr,
} }
EXPORT_SYMBOL(rdma_init_qp_attr); EXPORT_SYMBOL(rdma_init_qp_attr);
static inline int cma_zero_addr(const struct sockaddr *addr) static inline bool cma_zero_addr(const struct sockaddr *addr)
{ {
switch (addr->sa_family) { switch (addr->sa_family) {
case AF_INET: case AF_INET:
@ -1056,25 +1056,28 @@ static inline int cma_zero_addr(const struct sockaddr *addr)
case AF_IB: case AF_IB:
return ib_addr_any(&((struct sockaddr_ib *)addr)->sib_addr); return ib_addr_any(&((struct sockaddr_ib *)addr)->sib_addr);
default: default:
return 0; return false;
} }
} }
static inline int cma_loopback_addr(const struct sockaddr *addr) static inline bool cma_loopback_addr(const struct sockaddr *addr)
{ {
switch (addr->sa_family) { switch (addr->sa_family) {
case AF_INET: case AF_INET:
return ipv4_is_loopback(((struct sockaddr_in *) addr)->sin_addr.s_addr); return ipv4_is_loopback(
((struct sockaddr_in *)addr)->sin_addr.s_addr);
case AF_INET6: case AF_INET6:
return ipv6_addr_loopback(&((struct sockaddr_in6 *) addr)->sin6_addr); return ipv6_addr_loopback(
&((struct sockaddr_in6 *)addr)->sin6_addr);
case AF_IB: case AF_IB:
return ib_addr_loopback(&((struct sockaddr_ib *) addr)->sib_addr); return ib_addr_loopback(
&((struct sockaddr_ib *)addr)->sib_addr);
default: default:
return 0; return false;
} }
} }
static inline int cma_any_addr(const struct sockaddr *addr) static inline bool cma_any_addr(const struct sockaddr *addr)
{ {
return cma_zero_addr(addr) || cma_loopback_addr(addr); return cma_zero_addr(addr) || cma_loopback_addr(addr);
} }

4
include/rdma/ib.h
View file

@ -53,12 +53,12 @@ struct ib_addr {
#define sib_interface_id ib_u.uib_addr64[1] #define sib_interface_id ib_u.uib_addr64[1]
}; };
static inline int ib_addr_any(const struct ib_addr *a) static inline bool ib_addr_any(const struct ib_addr *a)
{ {
return ((a->sib_addr64[0] | a->sib_addr64[1]) == 0); return ((a->sib_addr64[0] | a->sib_addr64[1]) == 0);
} }
static inline int ib_addr_loopback(const struct ib_addr *a) static inline bool ib_addr_loopback(const struct ib_addr *a)
{ {
return ((a->sib_addr32[0] | a->sib_addr32[1] | return ((a->sib_addr32[0] | a->sib_addr32[1] |
a->sib_addr32[2] | (a->sib_addr32[3] ^ htonl(1))) == 0); a->sib_addr32[2] | (a->sib_addr32[3] ^ htonl(1))) == 0);