GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-03-18 05:04:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

serial: liteuart: fix return value check in liteuart_probe()

Browse source 
In case of error, the function devm_platform_get_and_ioremap_resource()
returns ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Fixes: 1da81e5562 ("drivers/tty/serial: add LiteUART driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210305034929.3234352-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2021-03-05 03:49:29 +00:00 • committed by Greg Kroah-Hartman
parent 81171e7d31
commit cebeddd6d0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/tty/serial/liteuart.c
View file

@ -270,8 +270,8 @@ static int liteuart_probe(struct platform_device *pdev)
/* get membase */ /* get membase */
port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (!port->membase) if (IS_ERR(port->membase))
return -ENXIO; return PTR_ERR(port->membase);
/* values not from device tree */ /* values not from device tree */
port->dev = &pdev->dev; port->dev = &pdev->dev;