GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-07 15:18:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

net: ethernet: mediatek: mtk_eth_soc: Add of_node_put() before goto

Browse source 
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a goto from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Nishka Dasgupta 2019-07-16 11:25:04 +05:30 • committed by David S. Miller
parent 64fc973dee
commit cf36dd2f77
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/ethernet/mediatek/mtk_eth_soc.c
View file

@ -2548,9 +2548,11 @@ static int mtk_probe(struct platform_device *pdev)
continue; continue;
err = mtk_add_mac(eth, mac_np); err = mtk_add_mac(eth, mac_np);
if (err) if (err) {
of_node_put(mac_np);
goto err_deinit_hw; goto err_deinit_hw;
} }
}
if (MTK_HAS_CAPS(eth->soc->caps, MTK_SHARED_INT)) { if (MTK_HAS_CAPS(eth->soc->caps, MTK_SHARED_INT)) {
err = devm_request_irq(eth->dev, eth->irq[0], err = devm_request_irq(eth->dev, eth->irq[0],