GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-04-24 23:34:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

tty: USB hangup is racy

Browse source 
The USB layer uses tty_hangup to deal with unplugs of the physical hardware
(analogous to loss of carrier) and then frees the resources. However the
tty_hangup is asynchronous. As the hangup can sleep we can use tty_vhangup
which is the non async version to avoid freeing resources too early.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Alan Cox 2009-09-19 13:13:23 -07:00 • committed by Live-CD User
parent 9b80fee149
commit d2b391822a
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/usb/serial/usb-serial.c
View file

@ -1161,10 +1161,7 @@ void usb_serial_disconnect(struct usb_interface *interface)
if (port) { if (port) {
struct tty_struct *tty = tty_port_tty_get(&port->port); struct tty_struct *tty = tty_port_tty_get(&port->port);
if (tty) { if (tty) {
/* The hangup will occur asynchronously but tty_vhangup(tty);
the object refcounts will sort out all the
cleanup */
tty_hangup(tty);
tty_kref_put(tty); tty_kref_put(tty);
} }
kill_traffic(port); kill_traffic(port);