GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-20 05:31:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

netpoll: remove return value from netpoll_rx_disable()

Browse source 
The netpoll_rx_disable() will always return 0, it is no use and looks wordy,
so remove the unnecessary code and get rid of it in _dev_open and _dev_close.

Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
dingtianhong 2013-05-27 19:53:31 +00:00 • committed by David S. Miller
parent 87227b8b2d
commit da6e378ba9
3 changed files with 7 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
include/linux/netpoll.h
View file

@ -53,10 +53,10 @@ struct netpoll_info {
}; };
#ifdef CONFIG_NETPOLL #ifdef CONFIG_NETPOLL
extern int netpoll_rx_disable(struct net_device *dev); extern void netpoll_rx_disable(struct net_device *dev);
extern void netpoll_rx_enable(struct net_device *dev); extern void netpoll_rx_enable(struct net_device *dev);
#else #else
static inline int netpoll_rx_disable(struct net_device *dev) { return 0; } static inline void netpoll_rx_disable(struct net_device *dev) { return; }
static inline void netpoll_rx_enable(struct net_device *dev) { return; } static inline void netpoll_rx_enable(struct net_device *dev) { return; }
#endif #endif

15
net/core/dev.c
View file

@ -1198,9 +1198,7 @@ static int __dev_open(struct net_device *dev)
* If we don't do this there is a chance ndo_poll_controller * If we don't do this there is a chance ndo_poll_controller
* or ndo_poll may be running while we open the device * or ndo_poll may be running while we open the device
*/ */
ret = netpoll_rx_disable(dev); netpoll_rx_disable(dev);
if (ret)
return ret;
ret = call_netdevice_notifiers(NETDEV_PRE_UP, dev); ret = call_netdevice_notifiers(NETDEV_PRE_UP, dev);
ret = notifier_to_errno(ret); ret = notifier_to_errno(ret);
@ -1309,9 +1307,7 @@ static int __dev_close(struct net_device *dev)
LIST_HEAD(single); LIST_HEAD(single);
/* Temporarily disable netpoll until the interface is down */ /* Temporarily disable netpoll until the interface is down */
retval = netpoll_rx_disable(dev); netpoll_rx_disable(dev);
if (retval)
return retval;
list_add(&dev->unreg_list, &single); list_add(&dev->unreg_list, &single);
retval = __dev_close_many(&single); retval = __dev_close_many(&single);
@ -1353,14 +1349,11 @@ static int dev_close_many(struct list_head *head)
*/ */
int dev_close(struct net_device *dev) int dev_close(struct net_device *dev)
{ {
int ret = 0;
if (dev->flags & IFF_UP) { if (dev->flags & IFF_UP) {
LIST_HEAD(single); LIST_HEAD(single);
/* Block netpoll rx while the interface is going down */ /* Block netpoll rx while the interface is going down */
ret = netpoll_rx_disable(dev); netpoll_rx_disable(dev);
if (ret)
return ret;
list_add(&dev->unreg_list, &single); list_add(&dev->unreg_list, &single);
dev_close_many(&single); dev_close_many(&single);
@ -1368,7 +1361,7 @@ int dev_close(struct net_device *dev)
netpoll_rx_enable(dev); netpoll_rx_enable(dev);
} }
return ret; return 0;
} }
EXPORT_SYMBOL(dev_close); EXPORT_SYMBOL(dev_close);

3
net/core/netpoll.c
View file

@ -247,7 +247,7 @@ static void netpoll_poll_dev(struct net_device *dev)
zap_completion_queue(); zap_completion_queue();
} }
int netpoll_rx_disable(struct net_device *dev) void netpoll_rx_disable(struct net_device *dev)
{ {
struct netpoll_info *ni; struct netpoll_info *ni;
int idx; int idx;
@ -257,7 +257,6 @@ int netpoll_rx_disable(struct net_device *dev)
if (ni) if (ni)
down(&ni->dev_lock); down(&ni->dev_lock);
srcu_read_unlock(&netpoll_srcu, idx); srcu_read_unlock(&netpoll_srcu, idx);
return 0;
} }
EXPORT_SYMBOL(netpoll_rx_disable); EXPORT_SYMBOL(netpoll_rx_disable);