GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-16 19:47:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

arm64: kexec: Add comment to explain use of __flush_icache_range()

Browse source 
Now that we understand the deadlock arising from flush_icache_range()
on the kexec crash kernel path, add a comment to justify the use of
__flush_icache_range() here.

Reported-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
This commit is contained in:
Will Deacon 2018-07-31 12:09:03 +01:00
parent eab1cecc12
commit dcab90d909
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
arch/arm64/kernel/machine_kexec.c
View file

@ -184,8 +184,15 @@ void machine_kexec(struct kimage *kimage)
/* Flush the reboot_code_buffer in preparation for its execution. */ /* Flush the reboot_code_buffer in preparation for its execution. */
__flush_dcache_area(reboot_code_buffer, arm64_relocate_new_kernel_size); __flush_dcache_area(reboot_code_buffer, arm64_relocate_new_kernel_size);
/*
* Although we've killed off the secondary CPUs, we don't update
* the online mask if we're handling a crash kernel and consequently
* need to avoid flush_icache_range(), which will attempt to IPI
* the offline CPUs. Therefore, we must use the __* variant here.
*/
__flush_icache_range((uintptr_t)reboot_code_buffer, __flush_icache_range((uintptr_t)reboot_code_buffer,
arm64_relocate_new_kernel_size); arm64_relocate_new_kernel_size);
/* Flush the kimage list and its buffers. */ /* Flush the kimage list and its buffers. */
kexec_list_flush(kimage); kexec_list_flush(kimage);