GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-07-03 12:52:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

vhost: don't hold onto file pointer for VHOST_SET_VRING_CALL

Browse source 
We already hold a reference to the eventfd_ctx, which is sufficient;
there's no need to hold a reference to the struct file as well.  So get
rid of vhost_virtqueue->call.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Eric Biggers 2018-01-06 14:52:19 -08:00 • committed by Michael S. Tsirkin
parent 03ee47ae8a
commit e050c7d93f
2 changed files with 5 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

20
drivers/vhost/vhost.c
View file

@ -321,7 +321,6 @@ static void vhost_vq_reset(struct vhost_dev *dev,
vq->error = NULL; vq->error = NULL;
vq->kick = NULL; vq->kick = NULL;
vq->call_ctx = NULL; vq->call_ctx = NULL;
vq->call = NULL;
vq->log_ctx = NULL; vq->log_ctx = NULL;
vhost_reset_is_le(vq); vhost_reset_is_le(vq);
vhost_disable_cross_endian(vq); vhost_disable_cross_endian(vq);
@ -623,8 +622,6 @@ void vhost_dev_cleanup(struct vhost_dev *dev)
fput(dev->vqs[i]->kick); fput(dev->vqs[i]->kick);
if (dev->vqs[i]->call_ctx) if (dev->vqs[i]->call_ctx)
eventfd_ctx_put(dev->vqs[i]->call_ctx); eventfd_ctx_put(dev->vqs[i]->call_ctx);
if (dev->vqs[i]->call)
fput(dev->vqs[i]->call);
vhost_vq_reset(dev, dev->vqs[i]); vhost_vq_reset(dev, dev->vqs[i]);
} }
vhost_dev_free_iovecs(dev); vhost_dev_free_iovecs(dev);
@ -1490,19 +1487,12 @@ long vhost_vring_ioctl(struct vhost_dev *d, int ioctl, void __user *argp)
r = -EFAULT; r = -EFAULT;
break; break;
} }
eventfp = f.fd == -1 ? NULL : eventfd_fget(f.fd); ctx = f.fd == -1 ? NULL : eventfd_ctx_fdget(f.fd);
if (IS_ERR(eventfp)) { if (IS_ERR(ctx)) {
r = PTR_ERR(eventfp); r = PTR_ERR(ctx);
break; break;
} }
if (eventfp != vq->call) { swap(ctx, vq->call_ctx);
filep = vq->call;
ctx = vq->call_ctx;
vq->call = eventfp;
vq->call_ctx = eventfp ?
eventfd_ctx_fileget(eventfp) : NULL;
} else
filep = eventfp;
break; break;
case VHOST_SET_VRING_ERR: case VHOST_SET_VRING_ERR:
if (copy_from_user(&f, argp, sizeof f)) { if (copy_from_user(&f, argp, sizeof f)) {
@ -1549,7 +1539,7 @@ long vhost_vring_ioctl(struct vhost_dev *d, int ioctl, void __user *argp)
if (pollstop && vq->handle_kick) if (pollstop && vq->handle_kick)
vhost_poll_stop(&vq->poll); vhost_poll_stop(&vq->poll);
if (ctx) if (!IS_ERR_OR_NULL(ctx))
eventfd_ctx_put(ctx); eventfd_ctx_put(ctx);
if (filep) if (filep)
fput(filep); fput(filep);

1
drivers/vhost/vhost.h
View file

@ -92,7 +92,6 @@ struct vhost_virtqueue {
struct vring_used __user *used; struct vring_used __user *used;
const struct vhost_umem_node *meta_iotlb[VHOST_NUM_ADDRS]; const struct vhost_umem_node *meta_iotlb[VHOST_NUM_ADDRS];
struct file *kick; struct file *kick;
struct file *call;
struct file *error; struct file *error;
struct eventfd_ctx *call_ctx; struct eventfd_ctx *call_ctx;
struct eventfd_ctx *error_ctx; struct eventfd_ctx *error_ctx;