ftrace/x86: Have x86 ftrace use the ftrace_modify_all_code()

To remove duplicate code, have the ftrace arch_ftrace_update_code()
use the generic ftrace_modify_all_code(). This requires that the
default ftrace_replace_code() becomes a weak function so that an
arch may override it.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
Steven Rostedt 2012-04-27 09:13:18 -04:00 committed by Steven Rostedt
parent 8ed3e2cfe4
commit e4f5d5440b
3 changed files with 5 additions and 15 deletions

View file

@ -435,7 +435,7 @@ static void run_sync(void)
local_irq_disable(); local_irq_disable();
} }
static void ftrace_replace_code(int enable) void ftrace_replace_code(int enable)
{ {
struct ftrace_rec_iter *iter; struct ftrace_rec_iter *iter;
struct dyn_ftrace *rec; struct dyn_ftrace *rec;
@ -493,18 +493,7 @@ void arch_ftrace_update_code(int command)
{ {
modifying_ftrace_code++; modifying_ftrace_code++;
if (command & FTRACE_UPDATE_CALLS) ftrace_modify_all_code(command);
ftrace_replace_code(1);
else if (command & FTRACE_DISABLE_CALLS)
ftrace_replace_code(0);
if (command & FTRACE_UPDATE_TRACE_FUNC)
ftrace_update_ftrace_func(ftrace_trace_function);
if (command & FTRACE_START_FUNC_RET)
ftrace_enable_ftrace_graph_caller();
else if (command & FTRACE_STOP_FUNC_RET)
ftrace_disable_ftrace_graph_caller();
modifying_ftrace_code--; modifying_ftrace_code--;
} }

View file

@ -314,6 +314,7 @@ ftrace_set_early_filter(struct ftrace_ops *ops, char *buf, int enable);
/* defined in arch */ /* defined in arch */
extern int ftrace_ip_converted(unsigned long ip); extern int ftrace_ip_converted(unsigned long ip);
extern int ftrace_dyn_arch_init(void *data); extern int ftrace_dyn_arch_init(void *data);
extern void ftrace_replace_code(int enable);
extern int ftrace_update_ftrace_func(ftrace_func_t func); extern int ftrace_update_ftrace_func(ftrace_func_t func);
extern void ftrace_caller(void); extern void ftrace_caller(void);
extern void ftrace_call(void); extern void ftrace_call(void);

View file

@ -1683,7 +1683,7 @@ __ftrace_replace_code(struct dyn_ftrace *rec, int enable)
return -1; /* unknow ftrace bug */ return -1; /* unknow ftrace bug */
} }
static void ftrace_replace_code(int update) void __weak ftrace_replace_code(int enable)
{ {
struct dyn_ftrace *rec; struct dyn_ftrace *rec;
struct ftrace_page *pg; struct ftrace_page *pg;
@ -1693,7 +1693,7 @@ static void ftrace_replace_code(int update)
return; return;
do_for_each_ftrace_rec(pg, rec) { do_for_each_ftrace_rec(pg, rec) {
failed = __ftrace_replace_code(rec, update); failed = __ftrace_replace_code(rec, enable);
if (failed) { if (failed) {
ftrace_bug(failed, rec->ip); ftrace_bug(failed, rec->ip);
/* Stop processing */ /* Stop processing */