GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-04-25 15:53:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

dmaengine: sprd: Fix potential NULL dereference in sprd_dma_probe()

Browse source 
platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap_nocache(e1, res->start, e2);

Fixes: 9b3b8171f7 ("dmaengine: sprd: Add Spreadtrum DMA driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Wei Yongjun 2018-05-07 01:40:34 +00:00 • committed by Vinod Koul
parent ab42ddb9eb
commit e891e41ee3
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/dma/sprd-dma.c
View file

@ -807,6 +807,8 @@ static int sprd_dma_probe(struct platform_device *pdev)
} }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -EINVAL;
sdev->glb_base = devm_ioremap_nocache(&pdev->dev, res->start, sdev->glb_base = devm_ioremap_nocache(&pdev->dev, res->start,
resource_size(res)); resource_size(res));
if (!sdev->glb_base) if (!sdev->glb_base)