GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-07-06 14:31:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

debug: softlockup looping fix

Browse source 
Rafael J. Wysocki reported weird, multi-seconds delays during
suspend/resume and bisected it back to:

  commit 82a1fcb902
  Author: Ingo Molnar <mingo@elte.hu>
  Date:   Fri Jan 25 21:08:02 2008 +0100

      softlockup: automatically detect hung TASK_UNINTERRUPTIBLE tasks

fix it:

 - restore the old wakeup mechanism
 - fix break usage in do_each_thread() { } while_each_thread().
 - fix the hotplug switch stmt, a fall-through case was broken.

Bisected-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Peter Zijlstra 2008-02-02 00:23:08 +01:00 • committed by Linus Torvalds
parent aa62999269
commit ed50d6cbc3
1 changed files with 20 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

30
kernel/softlockup.c
View file

@ -101,6 +101,10 @@ void softlockup_tick(void)
now = get_timestamp(this_cpu); now = get_timestamp(this_cpu);
/* Wake up the high-prio watchdog task every second: */
if (now > (touch_timestamp + 1))
wake_up_process(per_cpu(watchdog_task, this_cpu));
/* Warn about unreasonable delays: */ /* Warn about unreasonable delays: */
if (now <= (touch_timestamp + softlockup_thresh)) if (now <= (touch_timestamp + softlockup_thresh))
return; return;
@ -191,11 +195,11 @@ static void check_hung_uninterruptible_tasks(int this_cpu)
read_lock(&tasklist_lock); read_lock(&tasklist_lock);
do_each_thread(g, t) { do_each_thread(g, t) {
if (!--max_count) if (!--max_count)
break; goto unlock;
if (t->state & TASK_UNINTERRUPTIBLE) if (t->state & TASK_UNINTERRUPTIBLE)
check_hung_task(t, now); check_hung_task(t, now);
} while_each_thread(g, t); } while_each_thread(g, t);
unlock:
read_unlock(&tasklist_lock); read_unlock(&tasklist_lock);
} }
@ -218,14 +222,19 @@ static int watchdog(void *__bind_cpu)
* debug-printout triggers in softlockup_tick(). * debug-printout triggers in softlockup_tick().
*/ */
while (!kthread_should_stop()) { while (!kthread_should_stop()) {
set_current_state(TASK_INTERRUPTIBLE);
touch_softlockup_watchdog(); touch_softlockup_watchdog();
msleep_interruptible(10000); schedule();
if (kthread_should_stop())
break;
if (this_cpu != check_cpu) if (this_cpu != check_cpu)
continue; continue;
if (sysctl_hung_task_timeout_secs) if (sysctl_hung_task_timeout_secs)
check_hung_uninterruptible_tasks(this_cpu); check_hung_uninterruptible_tasks(this_cpu);
} }
return 0; return 0;
@ -259,13 +268,6 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
wake_up_process(per_cpu(watchdog_task, hotcpu)); wake_up_process(per_cpu(watchdog_task, hotcpu));
break; break;
#ifdef CONFIG_HOTPLUG_CPU #ifdef CONFIG_HOTPLUG_CPU
case CPU_UP_CANCELED:
case CPU_UP_CANCELED_FROZEN:
if (!per_cpu(watchdog_task, hotcpu))
break;
/* Unbind so it can run. Fall thru. */
kthread_bind(per_cpu(watchdog_task, hotcpu),
any_online_cpu(cpu_online_map));
case CPU_DOWN_PREPARE: case CPU_DOWN_PREPARE:
case CPU_DOWN_PREPARE_FROZEN: case CPU_DOWN_PREPARE_FROZEN:
if (hotcpu == check_cpu) { if (hotcpu == check_cpu) {
@ -275,6 +277,14 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
check_cpu = any_online_cpu(temp_cpu_online_map); check_cpu = any_online_cpu(temp_cpu_online_map);
} }
break; break;
case CPU_UP_CANCELED:
case CPU_UP_CANCELED_FROZEN:
if (!per_cpu(watchdog_task, hotcpu))
break;
/* Unbind so it can run. Fall thru. */
kthread_bind(per_cpu(watchdog_task, hotcpu),
any_online_cpu(cpu_online_map));
case CPU_DEAD: case CPU_DEAD:
case CPU_DEAD_FROZEN: case CPU_DEAD_FROZEN:
p = per_cpu(watchdog_task, hotcpu); p = per_cpu(watchdog_task, hotcpu);