GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-27 00:51:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

PM: EM: update the comments related to power scale

Browse source 
The Energy Model supports power values expressed in milli-Watts or in an
'abstract scale'. Update the related comments is the code to reflect that
state.

Reviewed-by: Quentin Perret <qperret@google.com>
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Lukasz Luba 2020-11-03 09:05:59 +00:00 • committed by Rafael J. Wysocki
parent 5a64f77569
commit f2c90b12e7
2 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
include/linux/energy_model.h
View file

@ -13,9 +13,8 @@
/** /**
* em_perf_state - Performance state of a performance domain * em_perf_state - Performance state of a performance domain
* @frequency: The frequency in KHz, for consistency with CPUFreq * @frequency: The frequency in KHz, for consistency with CPUFreq
* @power: The power consumed at this level, in milli-watts (by 1 CPU or * @power: The power consumed at this level (by 1 CPU or by a registered
by a registered device). It can be a total power: static and * device). It can be a total power: static and dynamic.
dynamic.
* @cost: The cost coefficient associated with this level, used during * @cost: The cost coefficient associated with this level, used during
* energy calculation. Equal to: power * max_frequency / frequency * energy calculation. Equal to: power * max_frequency / frequency
*/ */
@ -58,7 +57,7 @@ struct em_data_callback {
/** /**
* active_power() - Provide power at the next performance state of * active_power() - Provide power at the next performance state of
* a device * a device
* @power : Active power at the performance state in mW * @power : Active power at the performance state
* (modified) * (modified)
* @freq : Frequency at the performance state in kHz * @freq : Frequency at the performance state in kHz
* (modified) * (modified)
@ -69,8 +68,8 @@ struct em_data_callback {
* and frequency. * and frequency.
* *
* In case of CPUs, the power is the one of a single CPU in the domain, * In case of CPUs, the power is the one of a single CPU in the domain,
* expressed in milli-watts. It is expected to fit in the * expressed in milli-Watts or an abstract scale. It is expected to
* [0, EM_MAX_POWER] range. * fit in the [0, EM_MAX_POWER] range.
* *
* Return 0 on success. * Return 0 on success.
*/ */

2
kernel/power/energy_model.c
View file

@ -143,7 +143,7 @@ static int em_create_perf_table(struct device *dev, struct em_perf_domain *pd,
/* /*
* The power returned by active_state() is expected to be * The power returned by active_state() is expected to be
* positive, in milli-watts and to fit into 16 bits. * positive and to fit into 16 bits.
*/ */
if (!power || power > EM_MAX_POWER) { if (!power || power > EM_MAX_POWER) {
dev_err(dev, "EM: invalid power: %lu\n", dev_err(dev, "EM: invalid power: %lu\n",